Changeset 48497

Timestamp:

07/16/2020 09:42:48 PM (4 years ago)

Author:

whyisjake

Message:

Posts, Post Types: Ensure that all post stati are countable in wp_count_posts.

When wp_count_posts() is cached, it does so with all statuses defaulted to 0. The problem is however, if this is called before all plugins have registered their desired statuses, they won't have that default.

Fixes #49685.

Props obliviousharmony, SergeyBiryukov.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -2648 +2648 @@
     $counts = wp_cache_get( $cache_key, 'counts' );
     if ( false !== $counts ) {
+        // We may have cached this before every status was registered.
+        foreach ( get_post_stati() as $status ) {
+            if ( ! isset( $counts->{$status} ) ) {
+                $counts->{$status} = 0;
+            }
+        }
+
         /** This filter is documented in wp-includes/post.php */
         return apply_filters( 'wp_count_posts', $counts, $type, $perm );

trunk/tests/phpunit/tests/post.php

@@ -881 +881 @@
 
     /**
+     * @ticket 49685
+     */
+    function test_wp_count_posts_status_changes_visible() {
+        self::factory()->post->create_many( 3 );
+
+        // Trigger a cache.
+        wp_count_posts();
+
+        register_post_status( 'test' );
+
+        $counts = wp_count_posts();
+        $this->assertTrue( isset( $counts->test ) );
+        $this->assertEquals( 0, $counts->test );
+    }
+
+    /**
      * @ticket 13771
      */