Changeset 48497 for trunk/src/wp-includes/post.php

Timestamp:

07/16/2020 09:42:48 PM (6 years ago)

Author:

whyisjake

Message:

Posts, Post Types: Ensure that all post stati are countable in wp_count_posts.

When wp_count_posts() is cached, it does so with all statuses defaulted to 0. The problem is however, if this is called before all plugins have registered their desired statuses, they won't have that default.

Fixes #49685.

Props obliviousharmony, SergeyBiryukov.

File:

• trunk/src/wp-includes/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -2648 +2648 @@
         $counts = wp_cache_get( $cache_key, 'counts' );
         if ( false !== $counts ) {
+                // We may have cached this before every status was registered.
+                foreach ( get_post_stati() as $status ) {
+                        if ( ! isset( $counts->{$status} ) ) {
+                                $counts->{$status} = 0;
+                        }
+                }
+
                 /** This filter is documented in wp-includes/post.php */
                 return apply_filters( 'wp_count_posts', $counts, $type, $perm );