Changeset 48516

Timestamp:

07/20/2020 03:47:37 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: Simplify some assertions in phpunit/tests/media.php.

Correct comments per the documentation standards.

Follow-up to [48496].

See #22101.

File:

• trunk/tests/phpunit/tests/media.php (modified) (4 diffs)

trunk/tests/phpunit/tests/media.php

@@ -2948 +2948 @@
     }
 
-        /**
-         * @ticket 22101
-         */
+    /**
+     * @ticket 22101
+     */
     function test_gallery_shortcode_when_is_feed_true() {
 
         $this->go_to( '/?feed=rss2' );
 
-        // Default: Links to image attachment page url
+        // Default: Links to image attachment page URL.
         $actual = gallery_shortcode(
             array(
@@ -2963 +2963 @@
         $this->assertContains( '?attachment_id=', $actual );
 
-        // File: Links to image file url
+        // File: Links to image file URL.
         $actual = gallery_shortcode(
             array(
@@ -2970 +2970 @@
             )
         );
-        $this->assertTrue( 2 === substr_count( $actual, '.jpg' ) );
-
-        // None: Does not link
+        $this->assertEquals( 2, substr_count( $actual, '.jpg' ) );
+
+        // None: Does not link.
         $actual = gallery_shortcode(
             array(
@@ -2979 +2979 @@
             )
         );
-        $this->assertFalse( strpos( $actual, '<a ' ) );
+        $this->assertNotContains( '<a ', $actual );
     }