Changeset 48521 for trunk/tests/phpunit/tests/admin/includesListTable.php

Timestamp:

07/21/2020 12:27:46 AM (6 years ago)

Author:

whyisjake

Message:

Comments: Don't show the filter/pagination actions if there are no comments to list.

It doesn't make sense to be able to filter the comments list table when there are are no (trashed/spam) comments available.

Fixes #40188.
Props swissspidy, Jim_Panse, menakas, akbarhusen429, dinhtungdu, birgire, SergeyBiryukov, davidbaumwald, rebasaurus, whyisjake.

File:

• trunk/tests/phpunit/tests/admin/includesListTable.php (modified) (1 diff)

trunk/tests/phpunit/tests/admin/includesListTable.php

@@ -283 +283 @@
 
         /**
+         * @ticket 40188
+         */
+        public function test_filter_button_should_not_be_shown_if_there_are_no_comments() {
+                $table = _get_list_table( 'WP_Comments_List_Table', array( 'screen' => 'edit-comments' ) );
+
+                ob_start();
+                $table->extra_tablenav( 'top' );
+                $output = ob_get_clean();
+
+                $this->assertNotContains( 'id="post-query-submit"', $output );
+        }
+
+        /**
+         * @ticket 40188
+         */
+        public function test_filter_button_should_be_shown_if_there_are_comments() {
+                $post_id    = self::factory()->post->create();
+                $comment_id = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => $post_id,
+                                'comment_approved' => '1',
+                        )
+                );
+
+                $table = _get_list_table( 'WP_Comments_List_Table', array( 'screen' => 'edit-comments' ) );
+                $table->prepare_items();
+
+                ob_start();
+                $table->extra_tablenav( 'top' );
+                $output = ob_get_clean();
+
+                $this->assertContains( 'id="post-query-submit"', $output );
+        }
+
+        /**
+         * @ticket 40188
+         */
+        public function test_filter_comment_status_dropdown_should_be_shown_if_there_are_comments() {
+                $post_id    = self::factory()->post->create();
+                $comment_id = self::factory()->comment->create(
+                        array(
+                                'comment_post_ID'  => $post_id,
+                                'comment_approved' => '1',
+                        )
+                );
+
+                $table = _get_list_table( 'WP_Comments_List_Table', array( 'screen' => 'edit-comments' ) );
+                $table->prepare_items();
+
+                ob_start();
+                $table->extra_tablenav( 'top' );
+                $output = ob_get_clean();
+
+                $this->assertContains( 'id="filter-by-comment-type"', $output );
+                $this->assertContains( "<option value='comment'>", $output );
+        }
+
+        /**
          * @ticket 38341
          */