Changeset 48524

Timestamp:

07/21/2020 01:36:16 AM (6 years ago)

Author:

TimothyBlynJacobs

Message:

REST API: Make plugin installation tests more robust on alternate test environments.

The REST API plugin installation tests use the upgrader_pre_download filter to avoid downloading the test plugin from WordPress.org. Previously, this would apply to any upgrader, which caused issues if the testing environment required a language update.

Now, the filter only overwrites the file if the Plugin_Upgrader is being used which should hopefully prevent the issue.

Props pfefferle, TimothyBlynJacobs.
Fixes #50671.

File:

• trunk/tests/phpunit/tests/rest-api/rest-plugins-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-plugins-controller.php

@@ -1014 +1014 @@
                 add_filter(
                         'upgrader_pre_download',
-                        function () {
-                                return DIR_TESTDATA . '/link-manager.zip';
-                        }
+                        static function ( $reply, $package, $upgrader ) {
+                                if ( $upgrader instanceof Plugin_Upgrader ) {
+                                        $reply = DIR_TESTDATA . '/link-manager.zip';
+                                }
+
+                                return $reply;
+                        },
+                        10,
+                        3
                 );
         }