Changeset 48535 for trunk/src/wp-admin/includes/class-wp-debug-data.php

Timestamp:

07/21/2020 03:19:58 PM (6 years ago)

Author:

whyisjake

Message:

Site Health: Include new tests to check for the ability to upload files.

Several new checks:

• max_file_uploads
• file_uploads
• post_max_size
• upload_max_filesize
• upload_max
• max_file_uploads

In addition, new function parse_ini_size() that converts shorthand byte strings to bytes. Useful for size comparisons.

Fixes #50038.
Props dd32, donmhico, JavierCasares, SergeyBiryukov, ayeshrajans, Clorith, ipstenu, sabernhardt, whyisjake.

File:

• trunk/src/wp-admin/includes/class-wp-debug-data.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-debug-data.php

@@ -519 +519 @@
                         'value' => ( is_array( $imagick_version ) ? $imagick_version['versionString'] : $imagick_version ),
                 );
+
+                if ( ! function_exists( 'ini_get' ) ) {
+                        $info['wp-media']['fields']['ini_get'] = array(
+                                'label' => __( 'File upload settings' ),
+                                'value' => sprintf(
+                                        /* translators: %s: ini_get() */
+                                        __( 'Unable to determine some settings, as the %s function has been disabled.' ),
+                                        'ini_get()'
+                                ),
+                                'debug' => 'ini_get() is disabled',
+                        );
+                } else {
+                        // Get the PHP ini directive values.
+                        $post_max_size    = ini_get( 'post_max_size' );
+                        $upload_max_size  = ini_get( 'upload_max_filesize' );
+                        $max_file_uploads = ini_get( 'max_file_uploads' );
+                        $effective        = min( parse_ini_size( $post_max_size ), parse_ini_size( $upload_max_size ) );
+
+                        // Add info in Media section.
+                        $info['wp-media']['fields']['file_uploads']        = array(
+                                'label' => __( 'File uploads' ),
+                                'value' => empty( ini_get( 'file_uploads' ) ) ? __( 'Disabled' ) : __( 'Enabled' ),
+                                'debug' => 'File uploads is turned off',
+                        );
+                        $info['wp-media']['fields']['post_max_size']       = array(
+                                'label' => __( 'Max size of post data allowed' ),
+                                'value' => $post_max_size,
+                        );
+                        $info['wp-media']['fields']['upload_max_filesize'] = array(
+                                'label' => __( 'Max size of an uploaded file' ),
+                                'value' => $upload_max_size,
+                        );
+                        $info['wp-media']['fields']['upload_max']          = array(
+                                'label' => __( 'Max effective file size' ),
+                                'value' => size_format( $effective ),
+                        );
+                        $info['wp-media']['fields']['max_file_uploads']    = array(
+                                'label' => __( 'Max number of files allowed' ),
+                                'value' => number_format( $max_file_uploads ),
+                        );
+                }
 
                 // If Imagick is used as our editor, provide some more information about its limitations.