Changeset 48538 for trunk/src/wp-admin/includes/class-wp-site-health.php

Timestamp:

07/21/2020 03:38:40 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Remove parse_ini_size(), use the existing wp_convert_hr_to_bytes() function instead.

Follow-up to [48535].

See #50038.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -1957 +1957 @@
 
         /**
-         * Test if 'file_uploads' directive in PHP.ini is turned off
+         * Test if 'file_uploads' directive in PHP.ini is turned off.
          *
          * @since 5.5.0
@@ -2008 +2008 @@
                 }
 
-                if ( parse_ini_size( ini_get( 'post_max_size' ) ) !== parse_ini_size( ini_get( 'upload_max_filesize' ) ) ) {
+                $post_max_size   = ini_get( 'post_max_size' );
+                $upload_max_size = ini_get( 'upload_max_filesize' );
+
+                if ( wp_convert_hr_to_bytes( $post_max_size ) !== wp_convert_hr_to_bytes( $upload_max_size ) ) {
                         $result['label']       = __( 'Mismatched "post_max_size" and "upload_max_filesize" values.' );
                         $result['status']      = 'recommended';