Changeset 48559

Timestamp:

07/22/2020 12:13:21 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates.

Follow-up to [48548], [48558].

See #50662.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -2320 +2320 @@
             $cron_offset = $cron->time - time();
             if (
-                    $cron_offset >= $this->timeout_missed_cron &&
-                    $cron_offset < $this->timeout_late_cron
-                ) {
+                $cron_offset >= $this->timeout_missed_cron &&
+                $cron_offset < $this->timeout_late_cron
+            ) {
                 $this->last_late_cron = $cron->hook;
                 return true;
@@ -2350 +2350 @@
         $theme_filter_present   = has_filter( 'auto_update_theme' );
 
-        if ( ( ! $test_plugins_enabled && $ui_enabled_for_plugins ) || ( $test_themes_enabled && $ui_enabled_for_themes ) ) {
+        if ( ( ! $test_plugins_enabled && $ui_enabled_for_plugins )
+            || ( ! $test_themes_enabled && $ui_enabled_for_themes )
+        ) {
             return (object) array(
                 'status'  => 'critical',
@@ -2357 +2359 @@
         }
 
-        if ( ( ! $test_plugins_enabled && $plugin_filter_present ) && ( ! $test_themes_enabled && $theme_filter_present ) ) {
+        if ( ( ! $test_plugins_enabled && $plugin_filter_present )
+            && ( ! $test_themes_enabled && $theme_filter_present )
+        ) {
             return (object) array(
                 'status'  => 'recommended',