Changeset 48572

Timestamp:

07/23/2020 12:42:48 AM (4 years ago)

Author:

whyisjake

Message:

Media: Add "loading" as an allowed kses image attribute

With loading="lazy" being added to all images in [47554], let's ensure that it passes kses attributes too.

Fixes #50731.
Props TimothyBlynJacobs, peterwilsoncc, azaozz.

Location:

trunk

Files:

• src/wp-includes/kses.php (modified) (1 diff)
• tests/phpunit/tests/kses.php (modified) (2 diffs)

trunk/src/wp-includes/kses.php

@@ -231 +231 @@
             'height'   => true,
             'hspace'   => true,
+            'loading'  => true,
             'longdesc' => true,
             'vspace'   => true,

trunk/tests/phpunit/tests/kses.php

@@ -768 +768 @@
             array(
                 'img',
+                'loading="lazy"',
+                'loading="lazy"',
+            ),
+            array(
+                'img',
                 'onerror=alert(1)',
                 '',
@@ -1353 +1358 @@
         );
     }
+
+    /**
+     * Test filtering a standard img tag.
+     *
+     * @ticket 50731
+     */
+    function test_wp_kses_img_tag_standard_attributes() {
+        $html = array(
+            '<img',
+            'loading="lazy"',
+            'src="https://example.com/img.jpg"',
+            'width="1000"',
+            'height="1000"',
+            'alt=""',
+            'class="wp-image-1000"',
+            '/>',
+        );
+
+        $html = implode( ' ', $html );
+
+        $this->assertSame( $html, wp_kses_post( $html ) );
+    }
 }