Changeset 48625 for trunk/src/wp-admin/revision.php

Timestamp:

07/26/2020 09:24:00 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Revisions: Ensure the global $post remains the same after revision is restored.

Because wp_insert_post() and wp_transition_post_status() are called during the process, plugins can unexpectedly modify $post.

Props markparnell, tofandel, archon810, SergeyBiryukov.
Fixes #46671.

File:

• trunk/src/wp-admin/revision.php (modified) (1 diff)

trunk/src/wp-admin/revision.php

@@ -61 +61 @@
         check_admin_referer( "restore-post_{$revision->ID}" );
 
+        /*
+         * Ensure the global $post remains the same after revision is restored.
+         * Because wp_insert_post() and wp_transition_post_status() are called
+         * during the process, plugins can unexpectedly modify $post.
+         */
+        $backup_global_post = clone $post;
+
         wp_restore_post_revision( $revision->ID );
+
+        // Restore the global $post as it was before.
+        $post = $backup_global_post;
 
         $redirect = add_query_arg(