Changeset 48631

Timestamp:

07/27/2020 02:16:46 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Posts, Post Types: Pass the post type to get_lastpostdate() in get_lastpostmodified().

This ensures that the correct values are being compared when retrieving the result for custom post types.

Additionally, pass the $post_type parameter to get_lastpostdate and get_lastpostmodified filters.

Props mikaumoto, munyagu, donmhico, johnbillion, SergeyBiryukov.
Fixes #47777.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (5 diffs)
• tests/phpunit/tests/post/getLastPostDate.php (added)
• tests/phpunit/tests/post/getLastPostModified.php (added)

trunk/src/wp-includes/post.php

@@ -6621 +6621 @@
  */
 function get_lastpostdate( $timezone = 'server', $post_type = 'any' ) {
+        $date = _get_last_post_time( $timezone, 'date', $post_type );
+
         /**
          * Filters the most recent time that a post on the site was published.
          *
          * @since 2.3.0
-         *
-         * @param string|false $date     Date the last post was published. False on failure.
-         * @param string       $timezone Location to use for getting the post published date.
-         *                               See get_lastpostdate() for accepted `$timezone` values.
+         * @since 5.5.0 Added the `$post_type` parameter.
+         *
+         * @param string|false $date      Date the last post was published. False on failure.
+         * @param string       $timezone  Location to use for getting the post published date.
+         *                                See get_lastpostdate() for accepted `$timezone` values.
+         * @param string       $post_type The post type to check.
          */
-        return apply_filters( 'get_lastpostdate', _get_last_post_time( $timezone, 'date', $post_type ), $timezone );
+        return apply_filters( 'get_lastpostdate', $date, $timezone, $post_type );
 }
 
@@ -6662 +6666 @@
          */
         $lastpostmodified = apply_filters( 'pre_get_lastpostmodified', false, $timezone, $post_type );
+
         if ( false !== $lastpostmodified ) {
                 return $lastpostmodified;
@@ -6667 +6672 @@
 
         $lastpostmodified = _get_last_post_time( $timezone, 'modified', $post_type );
-
-        $lastpostdate = get_lastpostdate( $timezone );
+        $lastpostdate     = get_lastpostdate( $timezone, $post_type );
+
         if ( $lastpostdate > $lastpostmodified ) {
                 $lastpostmodified = $lastpostdate;
@@ -6677 +6682 @@
          *
          * @since 2.3.0
+         * @since 5.5.0 Added the `$post_type` parameter.
          *
          * @param string|false $lastpostmodified The most recent time that a post was modified, in 'Y-m-d H:i:s' format.
@@ -6682 +6688 @@
          * @param string       $timezone         Location to use for getting the post modified date.
          *                                       See get_lastpostdate() for accepted `$timezone` values.
+         * @param string       $post_type        The post type to check.
          */
-        return apply_filters( 'get_lastpostmodified', $lastpostmodified, $timezone );
+        return apply_filters( 'get_lastpostmodified', $lastpostmodified, $timezone, $post_type );
 }