Changeset 48654

Timestamp:

07/28/2020 01:00:40 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Themes: Display a message in theme updates list if an update requires a higher version of PHP or WordPress.

This applies to the WordPress Updates screen.

Props afragen, SergeyBiryukov.
Fixes #48491.

File:

• trunk/src/wp-admin/update-core.php (modified) (5 diffs)

trunk/src/wp-admin/update-core.php

@@ -410 +410 @@
         <tr>
                 <td class="check-column">
-                <?php if ( $compatible_php ) : ?>
-                        <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $plugin_file ); ?>" />
-                        <label for="<?php echo $checkbox_id; ?>" class="screen-reader-text">
-                                <?php
-                                /* translators: %s: Plugin name. */
-                                printf( __( 'Select %s' ), $plugin_data->Name );
-                                ?>
-                        </label>
-                <?php endif; ?>
+                        <?php if ( $compatible_php ) : ?>
+                                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $plugin_file ); ?>" />
+                                <label for="<?php echo $checkbox_id; ?>" class="screen-reader-text">
+                                        <?php
+                                        /* translators: %s: Plugin name. */
+                                        printf( __( 'Select %s' ), $plugin_data->Name );
+                                        ?>
+                                </label>
+                        <?php endif; ?>
                 </td>
                 <td class="plugin-title"><p>
@@ -430 +430 @@
                                 $plugin_data->update->new_version
                         );
+
                         echo ' ' . $details . $compat . $upgrade_notice;
+
                         if ( in_array( $plugin_file, $auto_updates, true ) ) {
                                 echo $auto_update_notice;
@@ -437 +439 @@
                 </p></td>
         </tr>
-                <?php
+                        <?php
         }
         ?>
@@ -500 +502 @@
 
         foreach ( $themes as $stylesheet => $theme ) {
+                $requires_wp  = isset( $theme->update['requires'] ) ? $theme->update['requires'] : null;
+                $requires_php = isset( $theme->update['requires_php'] ) ? $theme->update['requires_php'] : null;
+
+                $compatible_wp  = is_wp_version_compatible( $requires_wp );
+                $compatible_php = is_php_version_compatible( $requires_php );
+
+                $compat = '';
+
+                if ( ! $compatible_wp && ! $compatible_php ) {
+                        $compat .= '<br>' . __( 'This update doesn&#8217;t work with your versions of WordPress and PHP.' ) . '&nbsp;';
+                        if ( current_user_can( 'update_core' ) && current_user_can( 'update_php' ) ) {
+                                $compat .= sprintf(
+                                        /* translators: 1: URL to WordPress Updates screen, 2: URL to Update PHP page. */
+                                        __( '<a href="%1$s">Please update WordPress</a>, and then <a href="%2$s">learn more about updating PHP</a>.' ),
+                                        self_admin_url( 'update-core.php' ),
+                                        esc_url( wp_get_update_php_url() )
+                                );
+
+                                $annotation = wp_get_update_php_annotation();
+
+                                if ( $annotation ) {
+                                        $compat .= '</p><p><em>' . $annotation . '</em>';
+                                }
+                        } elseif ( current_user_can( 'update_core' ) ) {
+                                $compat .= sprintf(
+                                        /* translators: %s: URL to WordPress Updates screen. */
+                                        __( '<a href="%s">Please update WordPress</a>.' ),
+                                        self_admin_url( 'update-core.php' )
+                                );
+                        } elseif ( current_user_can( 'update_php' ) ) {
+                                $compat .= sprintf(
+                                        /* translators: %s: URL to Update PHP page. */
+                                        __( '<a href="%s">Learn more about updating PHP</a>.' ),
+                                        esc_url( wp_get_update_php_url() )
+                                );
+
+                                $annotation = wp_get_update_php_annotation();
+
+                                if ( $annotation ) {
+                                        $compat .= '</p><p><em>' . $annotation . '</em>';
+                                }
+                        }
+                } elseif ( ! $compatible_wp ) {
+                        $compat .= '<br>' . __( 'This update doesn&#8217;t work with your version of WordPress.' ) . '&nbsp;';
+                        if ( current_user_can( 'update_core' ) ) {
+                                $compat .= sprintf(
+                                        /* translators: %s: URL to WordPress Updates screen. */
+                                        __( '<a href="%s">Please update WordPress</a>.' ),
+                                        self_admin_url( 'update-core.php' )
+                                );
+                        }
+                } elseif ( ! $compatible_php ) {
+                        $compat .= '<br>' . __( 'This update doesn&#8217;t work with your version of PHP.' ) . '&nbsp;';
+                        if ( current_user_can( 'update_php' ) ) {
+                                $compat .= sprintf(
+                                        /* translators: %s: URL to Update PHP page. */
+                                        __( '<a href="%s">Learn more about updating PHP</a>.' ),
+                                        esc_url( wp_get_update_php_url() )
+                                );
+
+                                $annotation = wp_get_update_php_annotation();
+
+                                if ( $annotation ) {
+                                        $compat .= '</p><p><em>' . $annotation . '</em>';
+                                }
+                        }
+                }
+
                 $checkbox_id = 'checkbox_' . md5( $theme->get( 'Name' ) );
-
                 ?>
         <tr>
                 <td class="check-column">
-                        <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $stylesheet ); ?>" />
-                        <label for="<?php echo $checkbox_id; ?>" class="screen-reader-text">
-                                <?php
-                                /* translators: %s: Theme name. */
-                                printf( __( 'Select %s' ), $theme->display( 'Name' ) );
-                                ?>
-                        </label>
+                        <?php if ( $compatible_wp && $compatible_php ) : ?>
+                                <input type="checkbox" name="checked[]" id="<?php echo $checkbox_id; ?>" value="<?php echo esc_attr( $stylesheet ); ?>" />
+                                <label for="<?php echo $checkbox_id; ?>" class="screen-reader-text">
+                                        <?php
+                                        /* translators: %s: Theme name. */
+                                        printf( __( 'Select %s' ), $theme->display( 'Name' ) );
+                                        ?>
+                                </label>
+                        <?php endif; ?>
                 </td>
                 <td class="plugin-title"><p>
@@ -523 +594 @@
                                 $theme->update['new_version']
                         );
+
+                        echo ' ' . $compat;
+
                         if ( in_array( $stylesheet, $auto_updates, true ) ) {
                                 echo $auto_update_notice;