Changeset 48660

Timestamp:

07/28/2020 11:32:53 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress.

This applies to the Themes screen in Multisite network admin.

Props afragen, SergeyBiryukov.
Fixes #48507. See #48491.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-ms-themes-list-table.php (modified) (1 diff)
• update.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -562 +562 @@
                 }
 
-                if ( ! $allowed && current_user_can( 'delete_themes' ) && ! $this->is_site_themes && get_option( 'stylesheet' ) !== $stylesheet && get_option( 'template' ) !== $stylesheet ) {
+                if ( ! $allowed && ! $this->is_site_themes
+                        && current_user_can( 'delete_themes' )
+                        && get_option( 'stylesheet' ) !== $stylesheet
+                        && get_option( 'template' ) !== $stylesheet
+                ) {
                         $url = add_query_arg(
                                 array(

trunk/src/wp-admin/includes/update.php

@@ -643 +643 @@
         $active = $theme->is_allowed( 'network' ) ? ' active' : '';
 
+        $requires_wp  = isset( $response['requires'] ) ? $response['requires'] : null;
+        $requires_php = isset( $response['requires_php'] ) ? $response['requires_php'] : null;
+
+        $compatible_wp  = is_wp_version_compatible( $requires_wp );
+        $compatible_php = is_php_version_compatible( $compatible_php );
+
         printf(
                 '<tr class="plugin-update-tr%s" id="%s" data-slug="%s">' .
@@ -653 +659 @@
         );
 
-        if ( ! current_user_can( 'update_themes' ) ) {
-                printf(
-                        /* translators: 1: Theme name, 2: Details URL, 3: Additional link attributes, 4: Version number. */
-                        __( 'There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a>.' ),
-                        $theme['Name'],
-                        esc_url( $details_url ),
-                        sprintf(
-                                'class="thickbox open-plugin-details-modal" aria-label="%s"',
-                                /* translators: 1: Theme name, 2: Version number. */
-                                esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme['Name'], $response['new_version'] ) )
-                        ),
-                        $response['new_version']
-                );
-        } elseif ( empty( $response['package'] ) ) {
-                printf(
-                        /* translators: 1: Theme name, 2: Details URL, 3: Additional link attributes, 4: Version number. */
-                        __( 'There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a>. <em>Automatic update is unavailable for this theme.</em>' ),
-                        $theme['Name'],
-                        esc_url( $details_url ),
-                        sprintf(
-                                'class="thickbox open-plugin-details-modal" aria-label="%s"',
-                                /* translators: 1: Theme name, 2: Version number. */
-                                esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme['Name'], $response['new_version'] ) )
-                        ),
-                        $response['new_version']
-                );
+        if ( $compatible_wp && $compatible_php ) {
+                if ( ! current_user_can( 'update_themes' ) ) {
+                        printf(
+                                /* translators: 1: Theme name, 2: Details URL, 3: Additional link attributes, 4: Version number. */
+                                __( 'There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a>.' ),
+                                $theme['Name'],
+                                esc_url( $details_url ),
+                                sprintf(
+                                        'class="thickbox open-plugin-details-modal" aria-label="%s"',
+                                        /* translators: 1: Theme name, 2: Version number. */
+                                        esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme['Name'], $response['new_version'] ) )
+                                ),
+                                $response['new_version']
+                        );
+                } elseif ( empty( $response['package'] ) ) {
+                        printf(
+                                /* translators: 1: Theme name, 2: Details URL, 3: Additional link attributes, 4: Version number. */
+                                __( 'There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a>. <em>Automatic update is unavailable for this theme.</em>' ),
+                                $theme['Name'],
+                                esc_url( $details_url ),
+                                sprintf(
+                                        'class="thickbox open-plugin-details-modal" aria-label="%s"',
+                                        /* translators: 1: Theme name, 2: Version number. */
+                                        esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme['Name'], $response['new_version'] ) )
+                                ),
+                                $response['new_version']
+                        );
+                } else {
+                        printf(
+                                /* translators: 1: Theme name, 2: Details URL, 3: Additional link attributes, 4: Version number, 5: Update URL, 6: Additional link attributes. */
+                                __( 'There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a> or <a href="%5$s" %6$s>update now</a>.' ),
+                                $theme['Name'],
+                                esc_url( $details_url ),
+                                sprintf(
+                                        'class="thickbox open-plugin-details-modal" aria-label="%s"',
+                                        /* translators: 1: Theme name, 2: Version number. */
+                                        esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme['Name'], $response['new_version'] ) )
+                                ),
+                                $response['new_version'],
+                                wp_nonce_url( self_admin_url( 'update.php?action=upgrade-theme&theme=' ) . $theme_key, 'upgrade-theme_' . $theme_key ),
+                                sprintf(
+                                        'class="update-link" aria-label="%s"',
+                                        /* translators: %s: Theme name. */
+                                        esc_attr( sprintf( _x( 'Update %s now', 'theme' ), $theme['Name'] ) )
+                                )
+                        );
+                }
         } else {
-                printf(
-                        /* translators: 1: Theme name, 2: Details URL, 3: Additional link attributes, 4: Version number, 5: Update URL, 6: Additional link attributes. */
-                        __( 'There is a new version of %1$s available. <a href="%2$s" %3$s>View version %4$s details</a> or <a href="%5$s" %6$s>update now</a>.' ),
-                        $theme['Name'],
-                        esc_url( $details_url ),
-                        sprintf(
-                                'class="thickbox open-plugin-details-modal" aria-label="%s"',
-                                /* translators: 1: Theme name, 2: Version number. */
-                                esc_attr( sprintf( __( 'View %1$s version %2$s details' ), $theme['Name'], $response['new_version'] ) )
-                        ),
-                        $response['new_version'],
-                        wp_nonce_url( self_admin_url( 'update.php?action=upgrade-theme&theme=' ) . $theme_key, 'upgrade-theme_' . $theme_key ),
-                        sprintf(
-                                'class="update-link" aria-label="%s"',
+                if ( ! $compatible_wp && ! $compatible_php ) {
+                        printf(
                                 /* translators: %s: Theme name. */
-                                esc_attr( sprintf( _x( 'Update %s now', 'theme' ), $theme['Name'] ) )
-                        )
-                );
+                                __( 'There is a new version of %s available, but it doesn&#8217;t work with your versions of WordPress and PHP.' ),
+                                $theme['Name']
+                        );
+                        if ( current_user_can( 'update_core' ) && current_user_can( 'update_php' ) ) {
+                                printf(
+                                        /* translators: 1: URL to WordPress Updates screen, 2: URL to Update PHP page. */
+                                        ' ' . __( '<a href="%1$s">Please update WordPress</a>, and then <a href="%2$s">learn more about updating PHP</a>.' ),
+                                        self_admin_url( 'update-core.php' ),
+                                        esc_url( wp_get_update_php_url() )
+                                );
+                                wp_update_php_annotation( '</p><p><em>', '</em>' );
+                        } elseif ( current_user_can( 'update_core' ) ) {
+                                printf(
+                                        /* translators: %s: URL to WordPress Updates screen. */
+                                        ' ' . __( '<a href="%s">Please update WordPress</a>.' ),
+                                        self_admin_url( 'update-core.php' )
+                                );
+                        } elseif ( current_user_can( 'update_php' ) ) {
+                                printf(
+                                        /* translators: %s: URL to Update PHP page. */
+                                        ' ' . __( '<a href="%s">Learn more about updating PHP</a>.' ),
+                                        esc_url( wp_get_update_php_url() )
+                                );
+                                wp_update_php_annotation( '</p><p><em>', '</em>' );
+                        }
+                } elseif ( ! $compatible_wp ) {
+                        printf(
+                                /* translators: %s: Theme name. */
+                                __( 'There is a new version of %s available, but it doesn&#8217;t work with your version of WordPress.' ),
+                                $theme['Name']
+                        );
+                        if ( current_user_can( 'update_core' ) ) {
+                                printf(
+                                        /* translators: %s: URL to WordPress Updates screen. */
+                                        ' ' . __( '<a href="%s">Please update WordPress</a>.' ),
+                                        self_admin_url( 'update-core.php' )
+                                );
+                        }
+                } elseif ( ! $compatible_php ) {
+                        printf(
+                                /* translators: %s: Theme name. */
+                                __( 'There is a new version of %s available, but it doesn&#8217;t work with your version of PHP.' ),
+                                $theme['Name']
+                        );
+                        if ( current_user_can( 'update_php' ) ) {
+                                printf(
+                                        /* translators: %s: URL to Update PHP page. */
+                                        ' ' . __( '<a href="%s">Learn more about updating PHP</a>.' ),
+                                        esc_url( wp_get_update_php_url() )
+                                );
+                                wp_update_php_annotation( '</p><p><em>', '</em>' );
+                        }
+                }
         }