Changeset 48687 for branches/5.5

Timestamp:

07/29/2020 03:18:39 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Pass correct argument to clear_destination in Theme_Upgrader::install().

Follow-up to [48390].

Props afragen, sabernhardt.
Reviewed by desrosj, SergeyBiryukov.
Merges [48685] to the 5.5 branch.
Fixes #9757.

Location:

branches/5.5

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-plugin-upgrader.php (modified) (1 diff)
• src/wp-admin/includes/class-theme-upgrader.php (modified) (2 diffs)

branches/5.5/src/wp-admin/includes/class-plugin-upgrader.php

@@ -128 +128 @@
 
         add_filter( 'upgrader_source_selection', array( $this, 'check_package' ) );
+
         if ( $parsed_args['clear_update_cache'] ) {
             // Clear cache so wp_update_plugins() knows about the new plugin.

branches/5.5/src/wp-admin/includes/class-theme-upgrader.php

@@ -240 +240 @@
         add_filter( 'upgrader_source_selection', array( $this, 'check_package' ) );
         add_filter( 'upgrader_post_install', array( $this, 'check_parent_theme_filter' ), 10, 3 );
+
         if ( $parsed_args['clear_update_cache'] ) {
             // Clear cache so wp_update_themes() knows about the new theme.
@@ -249 +250 @@
                 'package'           => $package,
                 'destination'       => get_theme_root(),
-                'clear_destination' => $args['overwrite_package'],
+                'clear_destination' => $parsed_args['overwrite_package'],
                 'clear_working'     => true,
                 'hook_extra'        => array(