Changeset 48722

Timestamp:

08/04/2020 03:55:25 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Comments: Use the existing static variable instead of calling ::has_items() again in WP_Comments_List_Table::extra_tablenav().

Additionally, removed unnecessary esc_html() on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance.

Props whyisjake, SergeyBiryukov.
Fixes #40188.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-comments-list-table.php (modified) (2 diffs)
• class-wp-links-list-table.php (modified) (1 diff)
• class-wp-ms-sites-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -398 +398 @@
 
             $this->comment_status_dropdown( $comment_type );
+
             /**
              * Fires just before the Filter submit button for comment types.
@@ -407 +408 @@
             $output = ob_get_clean();
 
-            if ( ! empty( $output ) && $this->has_items() ) {
+            if ( ! empty( $output ) && $has_items ) {
                 echo $output;
-                submit_button( esc_html__( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
+                submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
             }
         }

trunk/src/wp-admin/includes/class-wp-links-list-table.php

@@ -116 +116 @@
 
             echo '<label class="screen-reader-text" for="cat_id">' . __( 'Filter by category' ) . '</label>';
+
             wp_dropdown_categories( $dropdown_options );
+
             submit_button( __( 'Filter' ), '', 'filter_action', false, array( 'id' => 'post-query-submit' ) );
             ?>

trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

@@ -333 +333 @@
              */
             do_action( 'restrict_manage_sites', $which );
+
             $output = ob_get_clean();
+
             if ( ! empty( $output ) ) {
                 echo $output;