WordPress.org

Make WordPress Core

Changeset 48734


Ignore:
Timestamp:
08/04/2020 05:52:36 PM (10 months ago)
Author:
SergeyBiryukov
Message:

Plugins: Move the "Successfully installed the plugin" string to the correct Plugin_Upgrader method.

The string refers to the installation, and belongs in the ::install_strings() method, not in ::upgrade_strings().

Props sswebster, nateinaction, SergeyBiryukov.
Fixes #50837.

Location:
trunk/src/wp-admin/includes
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/includes/class-plugin-upgrader.php

    r48685 r48734  
    6565        $this->strings['process_success']      = __( 'Plugin updated successfully.' );
    6666        $this->strings['process_bulk_success'] = __( 'Plugins updated successfully.' );
    67 
    68         /* translators: 1: Plugin name, 2: Plugin version. */
    69         $this->strings['process_success_specific'] = __( 'Successfully installed the plugin <strong>%1$s %2$s</strong>.' );
    7067    }
    7168
     
    8683        $this->strings['process_failed']      = __( 'Plugin installation failed.' );
    8784        $this->strings['process_success']     = __( 'Plugin installed successfully.' );
     85        /* translators: 1: Plugin name, 2: Plugin version. */
     86        $this->strings['process_success_specific'] = __( 'Successfully installed the plugin <strong>%1$s %2$s</strong>.' );
    8887
    8988        if ( ! empty( $this->skin->overwrite ) ) {
  • trunk/src/wp-admin/includes/class-theme-upgrader.php

    r48685 r48734  
    164164        $this->skin->api = $api;
    165165
    166         $this->strings['process_success_specific'] = $this->strings['parent_theme_install_success']; //, $api->name, $api->version );
     166        $this->strings['process_success_specific'] = $this->strings['parent_theme_install_success'];
    167167
    168168        $this->skin->feedback( 'parent_theme_prepare_install', $api->name, $api->version );
Note: See TracChangeset for help on using the changeset viewer.