Changeset 48735 for branches/5.5/src/wp-admin/includes/class-plugin-upgrader.php

Timestamp:

08/04/2020 06:02:45 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Plugins: Move the "Successfully installed the plugin" string to the correct Plugin_Upgrader method.

The string refers to the installation, and belongs in the ::install_strings() method, not in ::upgrade_strings().

Props sswebster, nateinaction.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48734] to the 5.5 branch.
Fixes #50837.

Location:

branches/5.5

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-plugin-upgrader.php (modified) (2 diffs)

branches/5.5/src/wp-admin/includes/class-plugin-upgrader.php

@@ -65 +65 @@
                 $this->strings['process_success']      = __( 'Plugin updated successfully.' );
                 $this->strings['process_bulk_success'] = __( 'Plugins updated successfully.' );
-
-                /* translators: 1: Plugin name, 2: Plugin version. */
-                $this->strings['process_success_specific'] = __( 'Successfully installed the plugin <strong>%1$s %2$s</strong>.' );
         }
 
@@ -86 +83 @@
                 $this->strings['process_failed']      = __( 'Plugin installation failed.' );
                 $this->strings['process_success']     = __( 'Plugin installed successfully.' );
+                /* translators: 1: Plugin name, 2: Plugin version. */
+                $this->strings['process_success_specific'] = __( 'Successfully installed the plugin <strong>%1$s %2$s</strong>.' );
 
                 if ( ! empty( $this->skin->overwrite ) ) {