Changeset 48752 for branches/5.5/src/wp-admin/includes/upgrade.php

Timestamp:

08/07/2020 04:33:39 PM (5 years ago)

Author:

SergeyBiryukov

Message:

Comments: Update comment cache in the upgrade routine for changing the comment_type DB field value in comments table.

This ensures that comment object cache is cleared after changing the comment type to comment instead of an empty string.

Add a unit test for _wp_batch_update_comment_type().

Follow-up to [47597], [47626], [48225], [48227].

Props imath, westonruter.
Reviewed by desrosj, SergeyBiryukov.
Merges [48748] and [48751] to the 5.5 branch.
Fixes #49236.

Location:

branches/5.5

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/upgrade.php (modified) (2 diffs)

branches/5.5/src/wp-admin/includes/upgrade.php

@@ -2175 +2175 @@
 
     if ( $wp_current_db_version < 48121 ) {
-        update_option( 'finished_updating_comment_type', 0 );
-        wp_schedule_single_event( time() + ( 1 * MINUTE_IN_SECONDS ), 'wp_update_comment_type_batch' );
-
         $comment_previously_approved = get_option( 'comment_whitelist', '' );
         update_option( 'comment_previously_approved', $comment_previously_approved );
@@ -2198 +2195 @@
         delete_option( 'blacklist_keys' );
         delete_option( 'blocklist_keys' );
+    }
+
+    if ( $wp_current_db_version < 48748 ) {
+        update_option( 'finished_updating_comment_type', 0 );
+        wp_schedule_single_event( time() + ( 1 * MINUTE_IN_SECONDS ), 'wp_update_comment_type_batch' );
     }
 }