Changeset 48790

Timestamp:

08/13/2020 12:32:03 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Change create_function() in phpunit/includes/plural-form-function.php to closure.

create_function() has been deprecated in PHP >= 7.2 and removed in PHP 8.

The only instance left in core was used in a test that was being skipped on PHP >= 7.2. This allows the test to run again.

Follow-up to [41722], [41730].

Props jrf.
Fixes #50899.

Location:

trunk/tests/phpunit

Files:

• includes/plural-form-function.php (modified) (1 diff)
• tests/pomo/pluralForms.php (modified) (1 diff)

trunk/tests/phpunit/includes/plural-form-function.php

@@ -8 +8 @@
  */
 function tests_make_plural_form_function( $nplurals, $expression ) {
-    $expression = str_replace( 'n', '$n', $expression );
-    $func_body  = "
-        \$index = (int)($expression);
-        return (\$index < $nplurals)? \$index : $nplurals - 1;";
+    $closure = function ( $n ) use ( $nplurals, $expression ) {
+        $expression = str_replace( 'n', $n, $expression );
 
-    // phpcs:ignore WordPress.PHP.RestrictedPHPFunctions.create_function_create_function
-    return create_function( '$n', $func_body );
+        // phpcs:ignore Squiz.PHP.Eval -- This is test code, not production.
+        $index = (int) eval( 'return ' . $expression . ';' );
+
+        return ( $index < $nplurals ) ? $index : $nplurals - 1;
+    };
+
+    return $closure;
 }

trunk/tests/phpunit/tests/pomo/pluralForms.php

@@ -75 +75 @@
      */
     public function test_regression( $lang, $nplurals, $expression ) {
-        if ( version_compare( phpversion(), '7.2', '>=' ) ) {
-            $this->markTestSkipped( 'Lambda functions are deprecated in PHP 7.2' );
-        }
-
         require_once dirname( dirname( __DIR__ ) ) . '/includes/plural-form-function.php';