Changeset 48792 for trunk

Timestamp:

08/14/2020 08:37:42 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Recognize define( 'WP_AUTO_UPDATE_CORE', 'minor' ) as an acceptable value.

Previously, it was only incidentally recognized as valid due to a loose comparison with true.

With the strict comparison added to WP_Site_Health_Auto_Updates::test_constants(), this was no longer the case.

Follow-up to [47841].

Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Fixes #50912.

File:

• trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-site-health-auto-updates.php

@@ -28 +28 @@
         public function run_tests() {
                 $tests = array(
-                        $this->test_constants( 'WP_AUTO_UPDATE_CORE', true ),
+                        $this->test_constants( 'WP_AUTO_UPDATE_CORE', array( true, 'minor' ) ),
                         $this->test_wp_version_check_attached(),
                         $this->test_filters_automatic_updater_disabled(),
@@ -61 +61 @@
          *
          * @since 5.2.0
-         *
-         * @param string $constant The name of the constant to check.
-         * @param bool   $value    The value that the constant should be, if set.
+         * @since 5.5.1 The `$value` parameter can accept an array.
+         *
+         * @param string $constant         The name of the constant to check.
+         * @param bool|string|array $value The value that the constant should be, if set,
+         *                                 or an array of acceptable values.
          * @return array The test results.
          */
         public function test_constants( $constant, $value ) {
-                if ( defined( $constant ) && constant( $constant ) !== $value ) {
+                $acceptable_values = (array) $value;
+
+                if ( defined( $constant ) && ! in_array( constant( $constant ), $acceptable_values, true ) ) {
                         return array(
                                 'description' => sprintf(