Changeset 48800

Timestamp:

08/16/2020 05:46:51 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Site Health: Only display the warning about the post_max_size PHP value when it's lower than upload_max_filesize.

Previously, the warning was displayed even if the value was higher than upload_max_filesize, which made the report inaccurate, as these values don't necessarily have to match.

Props oakesjosh, jeroenrotty, desrosj, Clorith.
Fixes #50945.

File:

• trunk/src/wp-admin/includes/class-wp-site-health.php (modified) (2 diffs)

trunk/src/wp-admin/includes/class-wp-site-health.php

@@ -2050 +2050 @@
         $upload_max_size = ini_get( 'upload_max_filesize' );
 
-        if ( wp_convert_hr_to_bytes( $post_max_size ) !== wp_convert_hr_to_bytes( $upload_max_size ) ) {
+        if ( wp_convert_hr_to_bytes( $post_max_size ) < wp_convert_hr_to_bytes( $upload_max_size ) ) {
             $result['label'] = sprintf(
                 /* translators: 1: post_max_size, 2: upload_max_filesize */
-                __( 'Mismatched "%1$s" and "%2$s" values.' ),
+                __( 'The "%1$s" value is smaller than "%2$s".' ),
                 'post_max_size',
                 'upload_max_filesize'
@@ -2062 +2062 @@
                 sprintf(
                     /* translators: 1: post_max_size, 2: upload_max_filesize */
-                    __( 'The settings for %1$s and %2$s are not the same, this could cause some problems when trying to upload files.' ),
+                    __( 'The setting for %1$s is smaller than %2$s, this could cause some problems when trying to upload files.' ),
                     '<code>post_max_size</code>',
                     '<code>upload_max_filesize</code>'