Changeset 48838

Timestamp:

08/21/2020 09:32:49 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Fix PHP 8 "argument must be passed by reference, value given" error in WP_Comment_Query::get_comments().

The WP native get_comment() function expects the first argument $comment to be passed by reference.

The PHP array_map() function, however, passes by value, not by reference, resulting in an "arguments must be passed by reference, value given" error.

The PHP native array_walk() function does pass by reference. Using this prevents the error on PHP 8 and maintains the existing behaviour on PHP < 8.

Props jrf.
See #50913.

File:

• trunk/src/wp-includes/class-wp-comment-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-comment-query.php

@@ -482 +482 @@
 
         // Convert to WP_Comment instances.
-        $comments = array_map( 'get_comment', $_comments );
+        array_walk( $_comments, 'get_comment' );
+        $comments = $_comments;
 
         if ( $this->query_vars['hierarchical'] ) {