Changeset 48872 for trunk/tests/phpunit/tests/canonical/sitemaps.php

Timestamp:

08/27/2020 01:28:24 AM (5 years ago)

Author:

peterwilsoncc

Message:

Sitemaps: Prevent incorrect redirection of paged sitemap requests.

Update redirect_canonical() to account for custom pagination and URL format used by sitemaps in order to follow standard practices.

Introduce the function get_sitemap_url() to simplify getting the index and provider URLs as needed.

Props jonathanstegall, pbiron, GamerZ, salvoaranzulla, peterwilsoncc.
Fixes #50910.

File:

• trunk/tests/phpunit/tests/canonical/sitemaps.php (modified) (1 diff)

trunk/tests/phpunit/tests/canonical/sitemaps.php

@@ -41 +41 @@
     }
 
+    /**
+     * Ensure sitemaps redirects work as expected with pretty permalinks.
+     *
+     * @dataProvider data_sitemaps_canonical_pretty_redirects
+     * @ticket 50910
+     */
+    public function test_sitemaps_canonical_pretty_redirects( $test_url, $expected ) {
+        $this->set_permalink_structure( '/%postname%/' );
+        $this->assertCanonical( $test_url, $expected, 50910 );
+    }
+
+    /**
+     * Data provider for test_sitemaps_canonical_pretty_redirects.
+     *
+     * @return array[] {
+     *     Data to test with.
+     *
+     *     @type string $0 The test URL.
+     *     @type string $1 The expected canonical URL.
+     * }
+     */
+    public function data_sitemaps_canonical_pretty_redirects() {
+        return array(
+            // Ugly/incorrect versions redirect correctly.
+            array( '/?sitemap=index', '/wp-sitemap.xml' ),
+            array( '/wp-sitemap.xml/', '/wp-sitemap.xml' ),
+            array( '/?sitemap=posts&sitemap-subtype=post', '/wp-sitemap-posts-post-1.xml' ),
+            array( '/?sitemap=posts&sitemap-subtype=post&paged=2', '/wp-sitemap-posts-post-2.xml' ),
+            array( '/?sitemap=taxonomies&sitemap-subtype=category', '/wp-sitemap-taxonomies-category-1.xml' ),
+            array( '/?sitemap=taxonomies&sitemap-subtype=category&paged=2', '/wp-sitemap-taxonomies-category-2.xml' ),
+
+            // Pretty versions don't redirect incorrectly.
+            array( '/wp-sitemap.xml', '/wp-sitemap.xml' ),
+            array( '/wp-sitemap-posts-post-1.xml', '/wp-sitemap-posts-post-1.xml' ),
+            array( '/wp-sitemap-posts-post-2.xml', '/wp-sitemap-posts-post-2.xml' ),
+            array( '/wp-sitemap-taxonomies-category-1.xml', '/wp-sitemap-taxonomies-category-1.xml' ),
+            array( '/wp-sitemap-taxonomies-category-2.xml', '/wp-sitemap-taxonomies-category-2.xml' ),
+        );
+    }
+
+    /**
+     * Ensure sitemaps redirects work as expected with ugly permalinks.
+     *
+     * @dataProvider data_sitemaps_canonical_ugly_redirects
+     * @ticket 50910
+     */
+    public function test_sitemaps_canonical_ugly_redirects( $test_url, $expected ) {
+        $this->set_permalink_structure( '' );
+        $this->assertCanonical( $test_url, $expected, 50910 );
+    }
+
+    /**
+     * Data provider for test_sitemaps_canonical_ugly_redirects.
+     *
+     * @return array[] {
+     *     Data to test with.
+     *
+     *     @type string $0 The test URL.
+     *     @type string $1 The expected canonical URL.
+     * }
+     */
+    public function data_sitemaps_canonical_ugly_redirects() {
+        return array(
+            // Ugly permalinks remain ugly.
+            array( '/?sitemap=index', '/?sitemap=index' ),
+            array( '/?sitemap=posts&sitemap-subtype=post', '/?sitemap=posts&sitemap-subtype=post' ),
+            array( '/?sitemap=posts&sitemap-subtype=post&paged=2', '/?sitemap=posts&sitemap-subtype=post&paged=2' ),
+            array( '/?sitemap=taxonomies&sitemap-subtype=category', '/?sitemap=taxonomies&sitemap-subtype=category' ),
+            array( '/?sitemap=taxonomies&sitemap-subtype=category&paged=2', '/?sitemap=taxonomies&sitemap-subtype=category&paged=2' ),
+        );
+    }
 }