Changeset 48880 for trunk/src/wp-admin/includes/template.php

Timestamp:

08/27/2020 02:46:22 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Taxonomy: Make sure wp_terms_checklist() and Walker_Category_Checklist::start_el() properly handle an array of strings as selected_cats or popular_cats values.

Even with these values documented as an array of integers, they can technically also accept an array of strings, e.g. as form results.

Add a unit test.

Props brianhogg, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51137.

File:

• trunk/src/wp-admin/includes/template.php (modified) (2 diffs)

trunk/src/wp-admin/includes/template.php

@@ -121 +121 @@
 
     if ( is_array( $parsed_args['selected_cats'] ) ) {
-        $args['selected_cats'] = $parsed_args['selected_cats'];
+        $args['selected_cats'] = array_map( 'intval', $parsed_args['selected_cats'] );
     } elseif ( $post_id ) {
         $args['selected_cats'] = wp_get_object_terms( $post_id, $taxonomy, array_merge( $args, array( 'fields' => 'ids' ) ) );
@@ -129 +129 @@
 
     if ( is_array( $parsed_args['popular_cats'] ) ) {
-        $args['popular_cats'] = $parsed_args['popular_cats'];
+        $args['popular_cats'] = array_map( 'intval', $parsed_args['popular_cats'] );
     } else {
         $args['popular_cats'] = get_terms(