Changeset 48900

Timestamp:

08/27/2020 10:23:53 PM (4 years ago)

Author:

SergeyBiryukov

Message:

Upgrade/Install: Only display the auto-update links on the Network Admin > Themes screen for themes that support the feature.

Follow-up to [48669], [48688].

Props afragen, pbiron, audrasjb, desrosj, SergeyBiryukov.
Merges [48899] to the 5.5 branch.
Fixes #51129.

Location:

branches/5.5

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (3 diffs)

branches/5.5/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -152 +152 @@
             $themes[ $filter ][ $key ] = $themes['all'][ $key ];
 
+            $theme_data = array(
+                'update_supported' => isset( $theme->update_supported ) ? $theme->update_supported : true,
+            );
+
+            // Extra info if known. array_merge() ensures $theme_data has precedence if keys collide.
+            if ( isset( $current->response[ $key ] ) ) {
+                $theme_data = array_merge( (array) $current->response[ $key ], $theme_data );
+            } elseif ( isset( $current->no_update[ $key ] ) ) {
+                $theme_data = array_merge( (array) $current->no_update[ $key ], $theme_data );
+            } else {
+                $theme_data['update_supported'] = false;
+            }
+
+            $theme->update_supported = $theme_data['update_supported'];
+
+            /*
+             * Create the expected payload for the auto_update_theme filter, this is the same data
+             * as contained within $updates or $no_updates but used when the Theme is not known.
+             */
+            $filter_payload = array(
+                'theme'        => $key,
+                'new_version'  => '',
+                'url'          => '',
+                'package'      => '',
+                'requires'     => '',
+                'requires_php' => '',
+            );
+
+            $filter_payload = array_merge( $filter_payload, array_intersect_key( $theme_data, $filter_payload ) );
+
+            $type = 'theme';
+            /** This filter is documented in wp-admin/includes/class-wp-automatic-updater.php */
+            $auto_update_forced = apply_filters( "auto_update_{$type}", null, (object) $filter_payload );
+
+            if ( ! is_null( $auto_update_forced ) ) {
+                $theme->auto_update_forced = $auto_update_forced;
+            }
+
             if ( $this->show_autoupdates ) {
-                if ( in_array( $key, $auto_updates, true ) ) {
-                    $themes['auto-update-enabled'][ $key ] = $themes['all'][ $key ];
+                $enabled = in_array( $key, $auto_updates, true ) && $theme->update_supported;
+                if ( isset( $theme->auto_update_forced ) ) {
+                    $enabled = (bool) $theme->auto_update_forced;
+                }
+
+                if ( $enabled ) {
+                    $themes['auto-update-enabled'][ $key ] = $theme;
                 } else {
-                    $themes['auto-update-disabled'][ $key ] = $themes['all'][ $key ];
+                    $themes['auto-update-disabled'][ $key ] = $theme;
                 }
             }
@@ -729 +772 @@
         $stylesheet = $theme->get_stylesheet();
 
-        if ( in_array( $stylesheet, $auto_updates, true ) ) {
+        if ( isset( $theme->auto_update_forced ) ) {
+            if ( $theme->auto_update_forced ) {
+                // Forced on.
+                $text = __( 'Auto-updates enabled' );
+            } else {
+                $text = __( 'Auto-updates disabled' );
+            }
+            $action     = 'unavailable';
+            $time_class = ' hidden';
+        } elseif ( empty( $theme->update_supported ) ) {
+            $text       = '';
+            $action     = 'unavailable';
+            $time_class = ' hidden';
+        } elseif ( in_array( $stylesheet, $auto_updates, true ) ) {
             $text       = __( 'Disable auto-updates' );
             $action     = 'disable';
@@ -748 +804 @@
         $url = add_query_arg( $query_args, 'themes.php' );
 
-        $html[] = sprintf(
-            '<a href="%s" class="toggle-auto-update aria-button-if-js" data-wp-action="%s">',
-            wp_nonce_url( $url, 'updates' ),
-            $action
-        );
-
-        $html[] = '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
-        $html[] = '<span class="label">' . $text . '</span>';
-        $html[] = '</a>';
-
-        $available_updates = get_site_transient( 'update_themes' );
+        if ( 'unavailable' === $action ) {
+            $html[] = '<span class="label">' . $text . '</span>';
+        } else {
+            $html[] = sprintf(
+                '<a href="%s" class="toggle-auto-update aria-button-if-js" data-wp-action="%s">',
+                wp_nonce_url( $url, 'updates' ),
+                $action
+            );
+
+            $html[] = '<span class="dashicons dashicons-update spin hidden" aria-hidden="true"></span>';
+            $html[] = '<span class="label">' . $text . '</span>';
+            $html[] = '</a>';
+
+        }
+
         if ( isset( $available_updates->response[ $stylesheet ] ) ) {
             $html[] = sprintf(