Changeset 48912 for trunk/tests/phpunit/tests/date/getTheDate.php

Timestamp:

08/31/2020 03:56:41 PM (6 years ago)

Author:

SergeyBiryukov

Message:

Date/Time: Make sure get_the_date() and related functions return correct time if the format was specified as false.

Technically, the $format argument should always be a string, but passing false used to work before [47808], so this restores backward compatibility.

The list of affected functions:

• get_the_date()
• get_the_time()
• get_comment_date()
• get_comment_time()

Props wittich, Rarst, akabarikalpesh, SergeyBiryukov.
Fixes #51184.

File:

• trunk/tests/phpunit/tests/date/getTheDate.php (modified) (3 diffs)

trunk/tests/phpunit/tests/date/getTheDate.php

@@ -11 +11 @@
          * @ticket 13771
          */
-        function test_get_the_date_with_id_returns_correct_time() {
+        function test_get_the_date_returns_correct_time_with_post_id() {
                 $post_id = self::factory()->post->create( array( 'post_date' => '2014-03-01 16:35:00' ) );
+
                 $this->assertEquals( 'March 1, 2014', get_the_date( 'F j, Y', $post_id ) );
         }
@@ -27 +28 @@
 
         /**
+         * @ticket 51184
+         */
+        function test_get_the_date_returns_correct_time_with_empty_format() {
+                $post_id = self::factory()->post->create( array( 'post_date' => '2020-08-29 01:51:00' ) );
+
+                $this->assertEquals( 'August 29, 2020', get_the_date( '', $post_id ) );
+                $this->assertEquals( 'August 29, 2020', get_the_date( false, $post_id ) );
+        }
+
+        /**
          * @ticket 28310
          */
-        function test_get_the_time_with_id_returns_correct_time() {
+        function test_get_the_time_returns_correct_time_with_post_id() {
                 $post_id = self::factory()->post->create( array( 'post_date' => '2014-03-01 16:35:00' ) );
+
                 $this->assertEquals( '16:35:00', get_the_time( 'H:i:s', $post_id ) );
         }
@@ -43 +55 @@
                 $this->assertFalse( get_the_time( 'h:i:s', 9 ) );
         }
+
+        /**
+         * @ticket 51184
+         */
+        function test_get_the_time_returns_correct_time_with_empty_format() {
+                $post_id = self::factory()->post->create( array( 'post_date' => '2020-08-29 01:51:00' ) );
+
+                $this->assertEquals( '1:51 am', get_the_time( '', $post_id ) );
+                $this->assertEquals( '1:51 am', get_the_time( false, $post_id ) );
+        }
 }