Changeset 48919

Timestamp:

08/31/2020 06:28:54 PM (3 years ago)

Author:

desrosj

Message:

Themes: Normalize the installed theme path in Theme_Installer_Skin::do_overwrite() before comparing with the uploaded theme.

This ensures that the data for the currently installed theme is picked up properly when uploading a theme update on Windows.

Follow-up to [48390].

Props bobbingwide, wpamitkumar, mukesh27.
Merges [48913] to the 5.5 branch.
Fixes #51182.

Location:

branches/5.5

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-theme-installer-skin.php (modified) (1 diff)

branches/5.5/src/wp-admin/includes/class-theme-installer-skin.php

@@ -207 +207 @@
 
         foreach ( $all_themes as $theme ) {
-            if ( rtrim( $theme->get_stylesheet_directory(), '/' ) !== $folder ) {
+            $stylesheet_dir = wp_normalize_path( $theme->get_stylesheet_directory() );
+
+            if ( rtrim( $stylesheet_dir, '/' ) !== $folder ) {
                 continue;
             }