Changeset 48921 for branches/5.5/tests/phpunit/tests/date/getPostTime.php

Timestamp:

08/31/2020 06:56:22 PM (5 years ago)

Author:

desrosj

Message:

Date/Time: Make sure get_the_date() and related functions return correct time if the format was specified as false.

Technically, the $format argument should always be a string, but passing false used to work before [47808], so this restores backward compatibility.

The list of affected functions:

• get_the_date()
• get_the_time()
• get_comment_date()
• get_comment_time()

Props wittich, Rarst, akabarikalpesh, SergeyBiryukov.
Merges [48912] to the 5.5 branch.
Fixes #51184.

Location:

branches/5.5

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/date/getPostTime.php (modified) (2 diffs)

branches/5.5/tests/phpunit/tests/date/getPostTime.php

@@ -11 +11 @@
      * @ticket 28310
      */
-    public function test_get_post_time_with_id_returns_correct_time() {
+    public function test_get_post_time_returns_correct_time_with_post_id() {
         $post_id = self::factory()->post->create( array( 'post_date' => '2014-03-01 16:35:00' ) );
+
         $this->assertEquals( '16:35:00', get_post_time( 'H:i:s', false, $post_id ) );
     }
@@ -29 +30 @@
      * @ticket 28310
      */
-    public function test_get_post_modified_time_with_id_returns_correct_time() {
+    public function test_get_post_modified_time_returns_correct_time_with_post_id() {
         $post_id = self::factory()->post->create( array( 'post_date' => '2014-03-01 16:35:00' ) );
+
         $this->assertEquals( '16:35:00', get_post_modified_time( 'H:i:s', false, $post_id ) );
     }