Changeset 48937 for trunk/tests/phpunit/tests/adminbar.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/adminbar.php (modified) (9 diffs)

trunk/tests/phpunit/tests/adminbar.php

@@ -44 +44 @@
         $nodes = $admin_bar->get_nodes();
         $this->assertFalse( $nodes['new-content']->parent );
-        $this->assertEquals( 'new-content', $nodes['add-new-content']->parent );
+        $this->assertSame( 'new-content', $nodes['add-new-content']->parent );
 
         _unregister_post_type( 'content' );
@@ -65 +65 @@
 
         $node1 = $admin_bar->get_node( 'test-node' );
-        $this->assertEquals( array( 'class' => 'test-class' ), $node1->meta );
+        $this->assertSame( array( 'class' => 'test-class' ), $node1->meta );
 
         $admin_bar->add_node(
@@ -75 +75 @@
 
         $node2 = $admin_bar->get_node( 'test-node' );
-        $this->assertEquals(
+        $this->assertSame(
             array(
                 'class'     => 'test-class',
@@ -101 +101 @@
 
         // Site menu points to the home page instead of the admin URL.
-        $this->assertEquals( home_url( '/' ), $node_site_name->href );
+        $this->assertSame( home_url( '/' ), $node_site_name->href );
 
         // No profile links as the user doesn't have any permissions on the site.
@@ -126 +126 @@
 
         // Site menu points to the admin URL.
-        $this->assertEquals( admin_url( '/' ), $node_site_name->href );
+        $this->assertSame( admin_url( '/' ), $node_site_name->href );
 
         $profile_url = admin_url( 'profile.php' );
 
         // Profile URLs point to profile.php.
-        $this->assertEquals( $profile_url, $node_my_account->href );
-        $this->assertEquals( $profile_url, $node_user_info->href );
-        $this->assertEquals( $profile_url, $node_edit_profile->href );
+        $this->assertSame( $profile_url, $node_my_account->href );
+        $this->assertSame( $profile_url, $node_user_info->href );
+        $this->assertSame( $profile_url, $node_edit_profile->href );
     }
 
@@ -178 +178 @@
 
         // Profile URLs should go to the user's primary blog.
-        $this->assertEquals( $primary_profile_url, $node_my_account->href );
-        $this->assertEquals( $primary_profile_url, $node_user_info->href );
-        $this->assertEquals( $primary_profile_url, $node_edit_profile->href );
+        $this->assertSame( $primary_profile_url, $node_my_account->href );
+        $this->assertSame( $primary_profile_url, $node_user_info->href );
+        $this->assertSame( $primary_profile_url, $node_edit_profile->href );
 
         restore_current_blog();
@@ -233 +233 @@
 
         // Profile URLs should go to the user's primary blog.
-        $this->assertEquals( $user_profile_url, $node_my_account->href );
-        $this->assertEquals( $user_profile_url, $node_user_info->href );
-        $this->assertEquals( $user_profile_url, $node_edit_profile->href );
+        $this->assertSame( $user_profile_url, $node_my_account->href );
+        $this->assertSame( $user_profile_url, $node_user_info->href );
+        $this->assertSame( $user_profile_url, $node_edit_profile->href );
 
         restore_current_blog();
@@ -464 +464 @@
 
         $this->assertNotNull( $wp_logo_node );
-        $this->assertSame( false, $wp_logo_node->href );
+        $this->assertFalse( $wp_logo_node->href );
         $this->assertArrayHasKey( 'tabindex', $wp_logo_node->meta );
         $this->assertSame( 0, $wp_logo_node->meta['tabindex'] );
@@ -688 +688 @@
         $query_params = array();
         wp_parse_str( $parsed_url['query'], $query_params );
-        $this->assertEquals( $uuid, $query_params['changeset_uuid'] );
+        $this->assertSame( $uuid, $query_params['changeset_uuid'] );
         $this->assertNotContains( 'changeset_uuid', $query_params['url'] );
     }