Context Navigation

← Previous Change
Next Change →

AddMeta.php

Timestamp:

09/02/2020 12:35:36 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

: 1 edited

trunk/tests/phpunit/tests/ajax/AddMeta.php (modified) (2 diffs)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/ajax/AddMeta.php

r47198	r48937
35	35	}
36	36
37		$this->assert~~Equals~~( '', get_post_meta( $p, 'testkey', true ) );
	37	$this->assertSame( '', get_post_meta( $p, 'testkey', true ) );
38	38	}
39	39
…	…
67	67	}
68	68
69		$this->assert~~Equals~~( '', get_post_meta( $p, 'testkey', true ) );
	69	$this->assertSame( '', get_post_meta( $p, 'testkey', true ) );
70	70	}
71	71	}

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 48937 for trunk/tests/phpunit/tests/ajax/AddMeta.php

Legend:

trunk/tests/phpunit/tests/ajax/AddMeta.php

Download in other formats: