Changeset 48937 for trunk/tests/phpunit/tests/basic.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/basic.php (modified) (6 diffs)

trunk/tests/phpunit/tests/basic.php

@@ -15 +15 @@
         preg_match( '#Copyright 2011-(\d+) by the contributors#', $license, $matches );
         $this_year = gmdate( 'Y' );
-        $this->assertEquals( $this_year, trim( $matches[1] ), "license.txt's year needs to be updated to $this_year." );
+        $this->assertSame( $this_year, trim( $matches[1] ), "license.txt's year needs to be updated to $this_year." );
     }
 
@@ -26 +26 @@
         $current_version = substr( $GLOBALS['wp_version'], 0, 3 );
         $latest_stable   = sprintf( '%s.x', (float) $current_version - 0.1 );
-        $this->assertEquals( $latest_stable, trim( $matches[0] ), "SECURITY.md's version needs to be updated to $latest_stable." );
+        $this->assertSame( $latest_stable, trim( $matches[0] ), "SECURITY.md's version needs to be updated to $latest_stable." );
     }
 
@@ -37 +37 @@
             $version .= '.0';
         }
-        $this->assertEquals( $version, $package_json['version'], "package.json's version needs to be updated to $version." );
+        $this->assertSame( $version, $package_json['version'], "package.json's version needs to be updated to $version." );
         return $package_json;
     }
@@ -54 +54 @@
 
     function test_strip_ws() {
-        $this->assertEquals( '', strip_ws( '' ) );
-        $this->assertEquals( 'foo', strip_ws( 'foo' ) );
-        $this->assertEquals( '', strip_ws( "\r\n\t  \n\r\t" ) );
+        $this->assertSame( '', strip_ws( '' ) );
+        $this->assertSame( 'foo', strip_ws( 'foo' ) );
+        $this->assertSame( '', strip_ws( "\r\n\t  \n\r\t" ) );
 
         $in  = "asdf\n";
@@ -76 +76 @@
         $expected .= 'foo';
 
-        $this->assertEquals( $expected, strip_ws( $in ) );
+        $this->assertSame( $expected, strip_ws( $in ) );
 
     }
@@ -94 +94 @@
         <ol id="authors"><form action="?import=wordpress&amp;step=2&amp;id=" method="post"><input type="hidden" name="_wpnonce" value="***" /><input type="hidden" name="_wp_http_referer" value="wp-test.php" /><li>Current author: <strong>Alex Shiels</strong><br />Create user  <input type="text" value="Alex Shiels" name="user[]" maxlength="30"> <br /> or map to existing<select name="userselect[0]">
 EOF;
-        $this->assertEquals( $expected, mask_input_value( $in ) );
+        $this->assertSame( $expected, mask_input_value( $in ) );
     }
 }