Changeset 48937 for trunk/tests/phpunit/tests/comment/getPageOfComment.php

Timestamp:

09/02/2020 12:35:36 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/comment/getPageOfComment.php (modified) (11 diffs)

trunk/tests/phpunit/tests/comment/getPageOfComment.php

@@ -29 +29 @@
                 $comment_first = self::factory()->comment->create_post_comments( $p, 1, array( 'comment_date' => '2013-09-14 00:00:00' ) );
 
-                $this->assertEquals( 4, get_page_of_comment( $comment_last[0], array( 'per_page' => 3 ) ) );
-                $this->assertEquals( 2, get_page_of_comment( $comment_last[0], array( 'per_page' => 10 ) ) );
-
-                $this->assertEquals( 1, get_page_of_comment( $comment_first[0], array( 'per_page' => 3 ) ) );
-                $this->assertEquals( 1, get_page_of_comment( $comment_first[0], array( 'per_page' => 10 ) ) );
+                $this->assertSame( 4, get_page_of_comment( $comment_last[0], array( 'per_page' => 3 ) ) );
+                $this->assertSame( 2, get_page_of_comment( $comment_last[0], array( 'per_page' => 10 ) ) );
+
+                $this->assertSame( 1, get_page_of_comment( $comment_first[0], array( 'per_page' => 3 ) ) );
+                $this->assertSame( 1, get_page_of_comment( $comment_first[0], array( 'per_page' => 10 ) ) );
         }
 
@@ -64 +64 @@
                 }
 
-                $this->assertEquals(
+                $this->assertSame(
                         2,
                         get_page_of_comment(
@@ -74 +74 @@
                         )
                 );
-                $this->assertEquals(
+                $this->assertSame(
                         3,
                         get_page_of_comment(
@@ -84 +84 @@
                         )
                 );
-                $this->assertEquals(
+                $this->assertSame(
                         5,
                         get_page_of_comment(
@@ -149 +149 @@
                         )
                 );
-                $this->assertEquals( 2, $page_trackbacks );
+                $this->assertSame( 2, $page_trackbacks );
 
                 $num_queries   = $wpdb->num_queries;
@@ -159 +159 @@
                         )
                 );
-                $this->assertEquals( 1, $page_comments );
+                $this->assertSame( 1, $page_comments );
 
                 $this->assertNotEquals( $num_queries, $wpdb->num_queries );
@@ -244 +244 @@
                 );
 
-                $this->assertEquals( 1, get_page_of_comment( $c1, array( 'per_page' => 2 ) ) );
+                $this->assertSame( 1, get_page_of_comment( $c1, array( 'per_page' => 2 ) ) );
 
                 wp_set_comment_status( $c3, '1' );
 
-                $this->assertEquals( 2, get_page_of_comment( $c1, array( 'per_page' => 2 ) ) );
+                $this->assertSame( 2, get_page_of_comment( $c1, array( 'per_page' => 2 ) ) );
         }
 
@@ -276 +276 @@
 
                 $found_0 = get_page_of_comment( $comments_0[0], array( 'per_page' => 2 ) );
-                $this->assertEquals( 3, $found_0 );
+                $this->assertSame( 3, $found_0 );
 
                 $found_1 = get_page_of_comment( $comments_1[1], array( 'per_page' => 2 ) );
-                $this->assertEquals( 2, $found_1 );
+                $this->assertSame( 2, $found_1 );
         }
 
@@ -358 +358 @@
                 update_option( 'comments_per_page', 2 );
 
-                $this->assertEquals( 2, get_page_of_comment( $c1 ) );
+                $this->assertSame( 2, get_page_of_comment( $c1 ) );
         }
 
@@ -398 +398 @@
                 update_option( 'comments_per_page', 1 );
 
-                $this->assertEquals( 2, get_page_of_comment( $c3 ) );
+                $this->assertSame( 2, get_page_of_comment( $c3 ) );
         }
 
@@ -438 +438 @@
                 update_option( 'comments_per_page', 1 );
 
-                $this->assertEquals( 2, get_page_of_comment( $c3 ) );
+                $this->assertSame( 2, get_page_of_comment( $c3 ) );
         }