Changeset 48937 for trunk/tests/phpunit/tests/cron.php

Timestamp:

09/02/2020 12:35:36 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/cron.php (modified) (9 diffs)

trunk/tests/phpunit/tests/cron.php

@@ -44 +44 @@
         $scheduled = wp_schedule_single_event( $timestamp, $hook );
         $this->assertTrue( $scheduled );
-        $this->assertEquals( $timestamp, wp_next_scheduled( $hook ) );
+        $this->assertSame( $timestamp, wp_next_scheduled( $hook ) );
 
         // It's a non-recurring event.
-        $this->assertEquals( '', wp_get_schedule( $hook ) );
+        $this->assertFalse( wp_get_schedule( $hook ) );
 
     }
@@ -60 +60 @@
         $this->assertTrue( $scheduled );
         // This returns the timestamp only if we provide matching args.
-        $this->assertEquals( $timestamp, wp_next_scheduled( $hook, $args ) );
+        $this->assertSame( $timestamp, wp_next_scheduled( $hook, $args ) );
         // These don't match so return nothing.
-        $this->assertEquals( false, wp_next_scheduled( $hook ) );
-        $this->assertEquals( false, wp_next_scheduled( $hook, array( 'bar' ) ) );
+        $this->assertFalse( wp_next_scheduled( $hook ) );
+        $this->assertFalse( wp_next_scheduled( $hook, array( 'bar' ) ) );
 
         // It's a non-recurring event.
-        $this->assertEquals( '', wp_get_schedule( $hook, $args ) );
+        $this->assertFalse( wp_get_schedule( $hook, $args ) );
     }
 
@@ -78 +78 @@
         $this->assertTrue( $scheduled );
         // It's scheduled for the right time.
-        $this->assertEquals( $timestamp, wp_next_scheduled( $hook ) );
+        $this->assertSame( $timestamp, wp_next_scheduled( $hook ) );
         // It's a recurring event.
-        $this->assertEquals( $recur, wp_get_schedule( $hook ) );
+        $this->assertSame( $recur, wp_get_schedule( $hook ) );
     }
 
@@ -93 +93 @@
         $this->assertTrue( $scheduled );
         // This returns the timestamp only if we provide matching args.
-        $this->assertEquals( $timestamp, wp_next_scheduled( $hook, $args ) );
+        $this->assertSame( $timestamp, wp_next_scheduled( $hook, $args ) );
         // These don't match so return nothing.
-        $this->assertEquals( false, wp_next_scheduled( $hook ) );
-        $this->assertEquals( false, wp_next_scheduled( $hook, array( 'bar' ) ) );
-
-        $this->assertEquals( $recur, wp_get_schedule( $hook, $args ) );
+        $this->assertFalse( wp_next_scheduled( $hook ) );
+        $this->assertFalse( wp_next_scheduled( $hook, array( 'bar' ) ) );
+
+        $this->assertSame( $recur, wp_get_schedule( $hook, $args ) );
 
     }
@@ -108 +108 @@
 
         wp_schedule_single_event( $timestamp, $hook );
-        $this->assertEquals( $timestamp, wp_next_scheduled( $hook ) );
+        $this->assertSame( $timestamp, wp_next_scheduled( $hook ) );
 
         // Now unschedule it and make sure it's gone.
         $unscheduled = wp_unschedule_event( $timestamp, $hook );
         $this->assertTrue( $unscheduled );
-        $this->assertEquals( false, wp_next_scheduled( $hook ) );
+        $this->assertFalse( wp_next_scheduled( $hook ) );
     }
 
@@ -276 +276 @@
 
         // The next event should be at +5 minutes, not +3.
-        $this->assertEquals( $ts1, wp_next_scheduled( $hook, $args ) );
+        $this->assertSame( $ts1, wp_next_scheduled( $hook, $args ) );
     }
 
@@ -295 +295 @@
 
         // The next event should be at +3 minutes, even though that one was scheduled second.
-        $this->assertEquals( $ts2, wp_next_scheduled( $hook, $args ) );
+        $this->assertSame( $ts2, wp_next_scheduled( $hook, $args ) );
         wp_unschedule_event( $ts2, $hook, $args );
         // Following event at +30 minutes should be there too.
-        $this->assertEquals( $ts1, wp_next_scheduled( $hook, $args ) );
+        $this->assertSame( $ts1, wp_next_scheduled( $hook, $args ) );
     }
 
@@ -314 +314 @@
 
         // The next event should be at +3 minutes.
-        $this->assertEquals( $ts1, wp_next_scheduled( $hook, $args ) );
+        $this->assertSame( $ts1, wp_next_scheduled( $hook, $args ) );
         wp_unschedule_event( $ts1, $hook, $args );
         // Following event should be there too.
-        $this->assertEquals( $ts2, wp_next_scheduled( $hook, $args ) );
+        $this->assertSame( $ts2, wp_next_scheduled( $hook, $args ) );
     }
 
@@ -471 +471 @@
 
         $this->assertEquals( $expected, $actual );
-        $this->assertEquals( $expected->timestamp, $actual2 );
+        $this->assertSame( $expected->timestamp, $actual2 );
     }