Changeset 48937 for trunk/tests/phpunit/tests/customize/panel.php

Timestamp:

09/02/2020 12:35:36 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/customize/panel.php (modified) (5 diffs)

trunk/tests/phpunit/tests/customize/panel.php

@@ -33 +33 @@
         $panel = new WP_Customize_Panel( $this->manager, 'foo' );
         $this->assertInternalType( 'int', $panel->instance_number );
-        $this->assertEquals( $this->manager, $panel->manager );
-        $this->assertEquals( 'foo', $panel->id );
-        $this->assertEquals( 160, $panel->priority );
-        $this->assertEquals( 'edit_theme_options', $panel->capability );
-        $this->assertEquals( '', $panel->theme_supports );
-        $this->assertEquals( '', $panel->title );
-        $this->assertEquals( '', $panel->description );
+        $this->assertSame( $this->manager, $panel->manager );
+        $this->assertSame( 'foo', $panel->id );
+        $this->assertSame( 160, $panel->priority );
+        $this->assertSame( 'edit_theme_options', $panel->capability );
+        $this->assertSame( '', $panel->theme_supports );
+        $this->assertSame( '', $panel->title );
+        $this->assertSame( '', $panel->description );
         $this->assertEmpty( $panel->sections );
-        $this->assertEquals( 'default', $panel->type );
-        $this->assertEquals( array( $panel, 'active_callback' ), $panel->active_callback );
+        $this->assertSame( 'default', $panel->type );
+        $this->assertSame( array( $panel, 'active_callback' ), $panel->active_callback );
     }
 
@@ -61 +61 @@
         $panel = new WP_Customize_Panel( $this->manager, 'foo', $args );
         foreach ( $args as $key => $value ) {
-            $this->assertEquals( $value, $panel->$key );
+            $this->assertSame( $value, $panel->$key );
         }
     }
@@ -70 +70 @@
     function test_construct_custom_type() {
         $panel = new Custom_Panel_Test( $this->manager, 'foo' );
-        $this->assertEquals( 'titleless', $panel->type );
+        $this->assertSame( 'titleless', $panel->type );
     }
 
@@ -120 +120 @@
         $panel = new WP_Customize_Panel( $this->manager, 'foo', $args );
         $data  = $panel->json();
-        $this->assertEquals( 'foo', $data['id'] );
+        $this->assertSame( 'foo', $data['id'] );
         foreach ( array( 'title', 'description', 'priority', 'type' ) as $key ) {
-            $this->assertEquals( $args[ $key ], $data[ $key ] );
+            $this->assertSame( $args[ $key ], $data[ $key ] );
         }
         $this->assertEmpty( $data['content'] );
@@ -168 +168 @@
         $this->assertTrue( $panel->check_capabilities() );
         $this->assertEmpty( $content );
-        $this->assertEquals( $customize_render_panel_count + 1, did_action( 'customize_render_panel' ), 'Unexpected did_action count for customize_render_panel' );
-        $this->assertEquals( 1, did_action( "customize_render_panel_{$panel->id}" ), "Unexpected did_action count for customize_render_panel_{$panel->id}" );
+        $this->assertSame( $customize_render_panel_count + 1, did_action( 'customize_render_panel' ), 'Unexpected did_action count for customize_render_panel' );
+        $this->assertSame( 1, did_action( "customize_render_panel_{$panel->id}" ), "Unexpected did_action count for customize_render_panel_{$panel->id}" );
     }