Changeset 48937 for trunk/tests/phpunit/tests/customize/partial.php

Timestamp:

09/02/2020 12:35:36 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/customize/partial.php (modified) (7 diffs)

trunk/tests/phpunit/tests/customize/partial.php

@@ -48 +48 @@
         $partial_id = 'blogname';
         $partial    = new WP_Customize_Partial( $this->selective_refresh, $partial_id );
-        $this->assertEquals( $partial_id, $partial->id );
-        $this->assertEquals( $this->selective_refresh, $partial->component );
-        $this->assertEquals( 'default', $partial->type );
+        $this->assertSame( $partial_id, $partial->id );
+        $this->assertSame( $this->selective_refresh, $partial->component );
+        $this->assertSame( 'default', $partial->type );
         $this->assertEmpty( $partial->selector );
-        $this->assertEquals( array( $partial_id ), $partial->settings );
-        $this->assertEquals( $partial_id, $partial->primary_setting );
-        $this->assertEquals( array( $partial, 'render_callback' ), $partial->render_callback );
-        $this->assertEquals( false, $partial->container_inclusive );
-        $this->assertEquals( true, $partial->fallback_refresh );
+        $this->assertSame( array( $partial_id ), $partial->settings );
+        $this->assertSame( $partial_id, $partial->primary_setting );
+        $this->assertSame( array( $partial, 'render_callback' ), $partial->render_callback );
+        $this->assertFalse( $partial->container_inclusive );
+        $this->assertTrue( $partial->fallback_refresh );
     }
 
@@ -103 +103 @@
         );
         $partial    = new WP_Customize_Partial( $this->selective_refresh, $partial_id, $args );
-        $this->assertEquals( $partial_id, $partial->id );
-        $this->assertEquals( $this->selective_refresh, $partial->component );
-        $this->assertEquals( $args['type'], $partial->type );
-        $this->assertEquals( $args['selector'], $partial->selector );
+        $this->assertSame( $partial_id, $partial->id );
+        $this->assertSame( $this->selective_refresh, $partial->component );
+        $this->assertSame( $args['type'], $partial->type );
+        $this->assertSame( $args['selector'], $partial->selector );
         $this->assertEqualSets( $args['settings'], $partial->settings );
-        $this->assertEquals( $args['primary_setting'], $partial->primary_setting );
-        $this->assertEquals( $args['render_callback'], $partial->render_callback );
-        $this->assertEquals( false, $partial->container_inclusive );
-        $this->assertEquals( false, $partial->fallback_refresh );
+        $this->assertSame( $args['primary_setting'], $partial->primary_setting );
+        $this->assertSame( $args['render_callback'], $partial->render_callback );
+        $this->assertFalse( $partial->container_inclusive );
+        $this->assertFalse( $partial->fallback_refresh );
         $this->assertContains( 'Lorem Ipsum', $partial->render() );
 
@@ -121 +121 @@
             )
         );
-        $this->assertEquals( array( 'blogdescription' ), $partial->settings );
-        $this->assertEquals( 'blogdescription', $partial->primary_setting );
+        $this->assertSame( array( 'blogdescription' ), $partial->settings );
+        $this->assertSame( 'blogdescription', $partial->primary_setting );
     }
 
@@ -133 +133 @@
         $partial = new WP_Customize_Partial( $this->selective_refresh, 'foo' );
         $id_data = $partial->id_data();
-        $this->assertEquals( 'foo', $id_data['base'] );
-        $this->assertEquals( array(), $id_data['keys'] );
+        $this->assertSame( 'foo', $id_data['base'] );
+        $this->assertSame( array(), $id_data['keys'] );
 
         $partial = new WP_Customize_Partial( $this->selective_refresh, 'bar[baz][quux]' );
         $id_data = $partial->id_data();
-        $this->assertEquals( 'bar', $id_data['base'] );
-        $this->assertEquals( array( 'baz', 'quux' ), $id_data['keys'] );
+        $this->assertSame( 'bar', $id_data['base'] );
+        $this->assertSame( array( 'baz', 'quux' ), $id_data['keys'] );
     }
 
@@ -181 +181 @@
      */
     function filter_customize_partial_render_with_id( $rendered, $partial, $container_context ) {
-        $this->assertEquals( sprintf( 'customize_partial_render_%s', $partial->id ), current_filter() );
+        $this->assertSame( sprintf( 'customize_partial_render_%s', $partial->id ), current_filter() );
         $this->assertTrue( false === $rendered || is_string( $rendered ) );
         $this->assertInstanceOf( 'WP_Customize_Partial', $partial );
@@ -250 +250 @@
         add_filter( "customize_partial_render_{$partial->id}", array( $this, 'filter_customize_partial_render_with_id' ), 10, 3 );
         $rendered = $partial->render();
-        $this->assertEquals( 'foo', $rendered );
-        $this->assertEquals( $count_filter_customize_partial_render + 1, $this->count_filter_customize_partial_render );
-        $this->assertEquals( $count_filter_customize_partial_render_with_id + 1, $this->count_filter_customize_partial_render_with_id );
+        $this->assertSame( 'foo', $rendered );
+        $this->assertSame( $count_filter_customize_partial_render + 1, $this->count_filter_customize_partial_render );
+        $this->assertSame( $count_filter_customize_partial_render_with_id + 1, $this->count_filter_customize_partial_render_with_id );
     }
 
@@ -273 +273 @@
         add_filter( "customize_partial_render_{$partial->id}", array( $this, 'filter_customize_partial_render_with_id' ), 10, 3 );
         $rendered = $partial->render();
-        $this->assertEquals( 'bar', $rendered );
-        $this->assertEquals( $count_filter_customize_partial_render + 1, $this->count_filter_customize_partial_render );
-        $this->assertEquals( $count_filter_customize_partial_render_with_id + 1, $this->count_filter_customize_partial_render_with_id );
+        $this->assertSame( 'bar', $rendered );
+        $this->assertSame( $count_filter_customize_partial_render + 1, $this->count_filter_customize_partial_render );
+        $this->assertSame( $count_filter_customize_partial_render_with_id + 1, $this->count_filter_customize_partial_render_with_id );
     }