Changeset 48937 for trunk/tests/phpunit/tests/date/getPostTime.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/date/getPostTime.php (modified) (5 diffs)

trunk/tests/phpunit/tests/date/getPostTime.php

@@ -14 +14 @@
         $post_id = self::factory()->post->create( array( 'post_date' => '2014-03-01 16:35:00' ) );
 
-        $this->assertEquals( '16:35:00', get_post_time( 'H:i:s', false, $post_id ) );
+        $this->assertSame( '16:35:00', get_post_time( 'H:i:s', false, $post_id ) );
     }
 
@@ -33 +33 @@
         $post_id = self::factory()->post->create( array( 'post_date' => '2014-03-01 16:35:00' ) );
 
-        $this->assertEquals( '16:35:00', get_post_modified_time( 'H:i:s', false, $post_id ) );
+        $this->assertSame( '16:35:00', get_post_modified_time( 'H:i:s', false, $post_id ) );
     }
 
@@ -65 +65 @@
         );
 
-        $this->assertEquals( $wp_timestamp, get_post_time( 'U', false, $post_id ) );
-        $this->assertEquals( $wp_timestamp, get_post_time( 'G', false, $post_id ) );
-        $this->assertEquals( $timestamp, get_post_time( 'U', true, $post_id ) );
-        $this->assertEquals( $timestamp, get_post_time( 'G', true, $post_id ) );
-        $this->assertEquals( $wp_timestamp, get_post_modified_time( 'U', false, $post_id ) );
-        $this->assertEquals( $wp_timestamp, get_post_modified_time( 'G', false, $post_id ) );
-        $this->assertEquals( $timestamp, get_post_modified_time( 'U', true, $post_id ) );
-        $this->assertEquals( $timestamp, get_post_modified_time( 'G', true, $post_id ) );
+        $this->assertSame( $wp_timestamp, get_post_time( 'U', false, $post_id ) );
+        $this->assertSame( $wp_timestamp, get_post_time( 'G', false, $post_id ) );
+        $this->assertSame( $timestamp, get_post_time( 'U', true, $post_id ) );
+        $this->assertSame( $timestamp, get_post_time( 'G', true, $post_id ) );
+        $this->assertSame( $wp_timestamp, get_post_modified_time( 'U', false, $post_id ) );
+        $this->assertSame( $wp_timestamp, get_post_modified_time( 'G', false, $post_id ) );
+        $this->assertSame( $timestamp, get_post_modified_time( 'U', true, $post_id ) );
+        $this->assertSame( $timestamp, get_post_modified_time( 'G', true, $post_id ) );
     }
 
@@ -93 +93 @@
         );
 
-        $this->assertEquals( $rfc3339, get_post_time( DATE_RFC3339, false, $post_id ) );
-        $this->assertEquals( $rfc3339_utc, get_post_time( DATE_RFC3339, true, $post_id ) );
-        $this->assertEquals( $rfc3339, get_post_time( DATE_RFC3339, false, $post_id, true ) );
-        $this->assertEquals( $rfc3339_utc, get_post_time( DATE_RFC3339, true, $post_id, true ) );
-        $this->assertEquals( $rfc3339, get_post_modified_time( DATE_RFC3339, false, $post_id ) );
-        $this->assertEquals( $rfc3339_utc, get_post_modified_time( DATE_RFC3339, true, $post_id ) );
-        $this->assertEquals( $rfc3339, get_post_modified_time( DATE_RFC3339, false, $post_id, true ) );
-        $this->assertEquals( $rfc3339_utc, get_post_modified_time( DATE_RFC3339, true, $post_id, true ) );
+        $this->assertSame( $rfc3339, get_post_time( DATE_RFC3339, false, $post_id ) );
+        $this->assertSame( $rfc3339_utc, get_post_time( DATE_RFC3339, true, $post_id ) );
+        $this->assertSame( $rfc3339, get_post_time( DATE_RFC3339, false, $post_id, true ) );
+        $this->assertSame( $rfc3339_utc, get_post_time( DATE_RFC3339, true, $post_id, true ) );
+        $this->assertSame( $rfc3339, get_post_modified_time( DATE_RFC3339, false, $post_id ) );
+        $this->assertSame( $rfc3339_utc, get_post_modified_time( DATE_RFC3339, true, $post_id ) );
+        $this->assertSame( $rfc3339, get_post_modified_time( DATE_RFC3339, false, $post_id, true ) );
+        $this->assertSame( $rfc3339_utc, get_post_modified_time( DATE_RFC3339, true, $post_id, true ) );
     }
 
@@ -122 +122 @@
         update_option( 'timezone_string', 'Europe/Kiev' );
 
-        $this->assertEquals( $rfc3339, get_post_time( DATE_RFC3339, true, $post_id ) );
-        $this->assertEquals( $rfc3339, get_post_modified_time( DATE_RFC3339, true, $post_id ) );
+        $this->assertSame( $rfc3339, get_post_time( DATE_RFC3339, true, $post_id ) );
+        $this->assertSame( $rfc3339, get_post_modified_time( DATE_RFC3339, true, $post_id ) );
     }
 }