Changeset 48937 for trunk/tests/phpunit/tests/feed/atom.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/feed/atom.php (modified) (8 diffs)

trunk/tests/phpunit/tests/feed/atom.php

@@ -98 +98 @@
 
         // Verify attributes.
-        $this->assertEquals( 'http://www.w3.org/2005/Atom', $atom[0]['attributes']['xmlns'] );
-        $this->assertEquals( 'http://purl.org/syndication/thread/1.0', $atom[0]['attributes']['xmlns:thr'] );
-        $this->assertEquals( site_url( '/wp-atom.php' ), $atom[0]['attributes']['xml:base'] );
+        $this->assertSame( 'http://www.w3.org/2005/Atom', $atom[0]['attributes']['xmlns'] );
+        $this->assertSame( 'http://purl.org/syndication/thread/1.0', $atom[0]['attributes']['xmlns:thr'] );
+        $this->assertSame( site_url( '/wp-atom.php' ), $atom[0]['attributes']['xml:base'] );
 
         // Verify the <feed> element is present and contains a <title> child element.
         $title = xml_find( $xml, 'feed', 'title' );
-        $this->assertEquals( get_option( 'blogname' ), $title[0]['content'] );
+        $this->assertSame( get_option( 'blogname' ), $title[0]['content'] );
 
         // Verify the <feed> element is present and contains a <updated> child element.
         $updated = xml_find( $xml, 'feed', 'updated' );
-        $this->assertEquals( strtotime( get_lastpostmodified() ), strtotime( $updated[0]['content'] ) );
+        $this->assertSame( strtotime( get_lastpostmodified() ), strtotime( $updated[0]['content'] ) );
 
         // Verify the <feed> element is present and contains a <subtitle> child element.
         $subtitle = xml_find( $xml, 'feed', 'subtitle' );
-        $this->assertEquals( get_option( 'blogdescription' ), $subtitle[0]['content'] );
+        $this->assertSame( get_option( 'blogdescription' ), $subtitle[0]['content'] );
 
         // Verify the <feed> element is present and contains two <link> child elements.
@@ -119 +119 @@
 
         // Verify the <feed> element is present and contains a <link rel="alternate"> child element.
-        $this->assertEquals( 'alternate', $link[0]['attributes']['rel'] );
-        $this->assertEquals( home_url(), $link[0]['attributes']['href'] );
+        $this->assertSame( 'alternate', $link[0]['attributes']['rel'] );
+        $this->assertSame( home_url(), $link[0]['attributes']['href'] );
 
         // Verify the <feed> element is present and contains a <link rel="href"> child element.
-        $this->assertEquals( 'self', $link[1]['attributes']['rel'] );
-        $this->assertEquals( home_url( '/?feed=atom' ), $link[1]['attributes']['href'] );
+        $this->assertSame( 'self', $link[1]['attributes']['rel'] );
+        $this->assertSame( home_url( '/?feed=atom' ), $link[1]['attributes']['href'] );
     }
 
@@ -155 +155 @@
             $author = xml_find( $entries[ $key ]['child'], 'author', 'name' );
             $user   = new WP_User( $post->post_author );
-            $this->assertEquals( $user->display_name, $author[0]['content'] );
+            $this->assertSame( $user->display_name, $author[0]['content'] );
 
             // Title.
             $title = xml_find( $entries[ $key ]['child'], 'title' );
-            $this->assertEquals( $post->post_title, $title[0]['content'] );
+            $this->assertSame( $post->post_title, $title[0]['content'] );
 
             // Link rel="alternate".
@@ -165 +165 @@
             foreach ( $link_alts as $link_alt ) {
                 if ( 'alternate' === $link_alt['attributes']['rel'] ) {
-                    $this->assertEquals( get_permalink( $post ), $link_alt['attributes']['href'] );
+                    $this->assertSame( get_permalink( $post ), $link_alt['attributes']['href'] );
                 }
             }
@@ -171 +171 @@
             // ID.
             $guid = xml_find( $entries[ $key ]['child'], 'id' );
-            $this->assertEquals( $post->guid, $id[0]['content'] );
+            $this->assertSame( $post->guid, $id[0]['content'] );
 
             // Updated.
             $updated = xml_find( $entries[ $key ]['child'], 'updated' );
-            $this->assertEquals( strtotime( $post->post_modified_gmt ), strtotime( $updated[0]['content'] ) );
+            $this->assertSame( strtotime( $post->post_modified_gmt ), strtotime( $updated[0]['content'] ) );
 
             // Published.
             $published = xml_find( $entries[ $key ]['child'], 'published' );
-            $this->assertEquals( strtotime( $post->post_date_gmt ), strtotime( $published[0]['content'] ) );
+            $this->assertSame( strtotime( $post->post_date_gmt ), strtotime( $published[0]['content'] ) );
 
             // Category.
@@ -194 +194 @@
             if ( ! $this->excerpt_only ) {
                 $content = xml_find( $entries[ $key ]['child'], 'content' );
-                $this->assertEquals( trim( apply_filters( 'the_content', $post->post_content ) ), trim( $content[0]['content'] ) );
+                $this->assertSame( trim( apply_filters( 'the_content', $post->post_content ) ), trim( $content[0]['content'] ) );
             }
 
@@ -201 +201 @@
             foreach ( $link_replies as $link_reply ) {
                 if ( 'replies' === $link_reply['attributes']['rel'] && 'application/atom+xml' === $link_reply['attributes']['type'] ) {
-                    $this->assertEquals( get_post_comments_feed_link( $post->ID, 'atom' ), $link_reply['attributes']['href'] );
+                    $this->assertSame( get_post_comments_feed_link( $post->ID, 'atom' ), $link_reply['attributes']['href'] );
                 }
             }
@@ -274 +274 @@
             foreach ( (array) $links as $link ) {
                 if ( 'enclosure' === $link['attributes']['rel'] ) {
-                    $this->assertEquals( $enclosures[ $i ]['expected']['href'], $link['attributes']['href'] );
+                    $this->assertSame( $enclosures[ $i ]['expected']['href'], $link['attributes']['href'] );
                     $this->assertEquals( $enclosures[ $i ]['expected']['length'], $link['attributes']['length'] );
-                    $this->assertEquals( $enclosures[ $i ]['expected']['type'], $link['attributes']['type'] );
+                    $this->assertSame( $enclosures[ $i ]['expected']['type'], $link['attributes']['type'] );
                     $i++;
                 }