Changeset 48937 for trunk/tests/phpunit/tests/formatting/JSEscape.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/formatting/JSEscape.php (modified) (3 diffs)

trunk/tests/phpunit/tests/formatting/JSEscape.php

@@ -7 +7 @@
     function test_js_escape_simple() {
         $out = esc_js( 'foo bar baz();' );
-        $this->assertEquals( 'foo bar baz();', $out );
+        $this->assertSame( 'foo bar baz();', $out );
     }
 
@@ -13 +13 @@
         $out = esc_js( 'foo "bar" \'baz\'' );
         // Does it make any sense to change " into "?  Why not \"?
-        $this->assertEquals( "foo "bar" \'baz\'", $out );
+        $this->assertSame( "foo "bar" \'baz\'", $out );
     }
 
@@ -20 +20 @@
         $out = esc_js( 'foo ' . $bs . 't bar ' . $bs . $bs . ' baz' );
         // \t becomes t - bug?
-        $this->assertEquals( 'foo t bar ' . $bs . $bs . ' baz', $out );
+        $this->assertSame( 'foo t bar ' . $bs . $bs . ' baz', $out );
     }
 
     function test_js_escape_amp() {
         $out = esc_js( 'foo & bar &baz;  ' );
-        $this->assertEquals( 'foo & bar &baz;  ', $out );
+        $this->assertSame( 'foo & bar &baz;  ', $out );
     }
 
     function test_js_escape_quote_entity() {
         $out = esc_js( 'foo ' bar ' baz &' );
-        $this->assertEquals( "foo \\' bar \\' baz &", $out );
+        $this->assertSame( "foo \\' bar \\' baz &", $out );
     }