Changeset 48937 for trunk/tests/phpunit/tests/formatting/SanitizeFileName.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/formatting/SanitizeFileName.php (modified) (6 diffs)

trunk/tests/phpunit/tests/formatting/SanitizeFileName.php

@@ -8 +8 @@
         # r17990
         $file_name = sanitize_file_name( 'test.phtml.txt' );
-        $this->assertEquals( 'test.phtml_.txt', $file_name );
+        $this->assertSame( 'test.phtml_.txt', $file_name );
     }
 
@@ -18 +18 @@
         }
         $string .= 'test';
-        $this->assertEquals( 'testtest', sanitize_file_name( $string ) );
+        $this->assertSame( 'testtest', sanitize_file_name( $string ) );
     }
 
@@ -27 +27 @@
         $in  = 'àáâãäåæçèéêëìíîïñòóôõöøùúûüýÿ';
         $out = 'aaaaaaaeceeeeiiiinoooooouuuuyy';
-        $this->assertEquals( $out, sanitize_file_name( $in ) );
+        $this->assertSame( $out, sanitize_file_name( $in ) );
     }
 
@@ -44 +44 @@
 
         foreach ( $urls as $test => $expected ) {
-            $this->assertEquals( $expected, sanitize_file_name( $test ) );
+            $this->assertSame( $expected, sanitize_file_name( $test ) );
         }
     }
 
     function test_replaces_any_number_of_hyphens_with_one_hyphen() {
-        $this->assertEquals( 'a-t-t', sanitize_file_name( 'a----t----t' ) );
+        $this->assertSame( 'a-t-t', sanitize_file_name( 'a----t----t' ) );
     }
 
     function test_trims_trailing_hyphens() {
-        $this->assertEquals( 'a-t-t', sanitize_file_name( 'a----t----t----' ) );
+        $this->assertSame( 'a-t-t', sanitize_file_name( 'a----t----t----' ) );
     }
 
     function test_replaces_any_amount_of_whitespace_with_one_hyphen() {
-        $this->assertEquals( 'a-t', sanitize_file_name( 'a          t' ) );
-        $this->assertEquals( 'a-t', sanitize_file_name( "a    \n\n\nt" ) );
+        $this->assertSame( 'a-t', sanitize_file_name( 'a          t' ) );
+        $this->assertSame( 'a-t', sanitize_file_name( "a    \n\n\nt" ) );
     }
 
@@ -65 +65 @@
      */
     function test_replaces_percent_sign() {
-        $this->assertEquals( 'a22b.jpg', sanitize_file_name( 'a%22b.jpg' ) );
+        $this->assertSame( 'a22b.jpg', sanitize_file_name( 'a%22b.jpg' ) );
     }
 
     function test_replaces_unnamed_file_extensions() {
         // Test filenames with both supported and unsupported extensions.
-        $this->assertEquals( 'unnamed-file.exe', sanitize_file_name( '_.exe' ) );
-        $this->assertEquals( 'unnamed-file.jpg', sanitize_file_name( '_.jpg' ) );
+        $this->assertSame( 'unnamed-file.exe', sanitize_file_name( '_.exe' ) );
+        $this->assertSame( 'unnamed-file.jpg', sanitize_file_name( '_.jpg' ) );
     }
 
     function test_replaces_unnamed_file_extensionless() {
         // Test a filenames that becomes extensionless.
-        $this->assertEquals( 'no-extension', sanitize_file_name( '_.no-extension' ) );
+        $this->assertSame( 'no-extension', sanitize_file_name( '_.no-extension' ) );
     }
 
@@ -83 +83 @@
      */
     function test_replaces_invalid_utf8_characters( $input, $expected ) {
-        $this->assertEquals( $expected, sanitize_file_name( $input ) );
+        $this->assertSame( $expected, sanitize_file_name( $input ) );
     }