Changeset 48937 for trunk/tests/phpunit/tests/formatting/SanitizeUser.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/formatting/SanitizeUser.php (modified) (3 diffs)

trunk/tests/phpunit/tests/formatting/SanitizeUser.php

@@ -8 +8 @@
         $input    = 'Captain <strong>Awesome</strong>';
         $expected = is_multisite() ? 'captain awesome' : 'Captain Awesome';
-        $this->assertEquals( $expected, sanitize_user( $input ) );
+        $this->assertSame( $expected, sanitize_user( $input ) );
     }
 
@@ -19 +19 @@
         }
 
-        $this->assertEquals( $expected, sanitize_user( 'AT&amp;T' ) );
+        $this->assertSame( $expected, sanitize_user( 'AT&amp;T' ) );
     }
 
@@ -30 +30 @@
         }
 
-        $this->assertEquals( $expected, sanitize_user( 'AT&amp;T Test;' ) );
+        $this->assertSame( $expected, sanitize_user( 'AT&amp;T Test;' ) );
     }
 
     function test_strips_percent_encoded_octets() {
         $expected = is_multisite() ? 'franois' : 'Franois';
-        $this->assertEquals( $expected, sanitize_user( 'Fran%c3%a7ois' ) );
+        $this->assertSame( $expected, sanitize_user( 'Fran%c3%a7ois' ) );
     }
     function test_optional_strict_mode_reduces_to_safe_ascii_subset() {
-        $this->assertEquals( 'abc', sanitize_user( '()~ab~ˆcˆ!', true ) );
+        $this->assertSame( 'abc', sanitize_user( '()~ab~ˆcˆ!', true ) );
     }
 }