Changeset 48937 for trunk/tests/phpunit/tests/formatting/Slashit.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/formatting/Slashit.php (modified) (4 diffs)

trunk/tests/phpunit/tests/formatting/Slashit.php

@@ -6 +6 @@
 class Tests_Formatting_Slashit extends WP_UnitTestCase {
     function test_backslashes_middle_numbers() {
-        $this->assertEquals( "\\a-!9\\a943\\b\\c", backslashit( 'a-!9a943bc' ) );
+        $this->assertSame( "\\a-!9\\a943\\b\\c", backslashit( 'a-!9a943bc' ) );
     }
 
     function test_backslashes_alphas() {
-        $this->assertEquals( "\\a943\\b\\c", backslashit( 'a943bc' ) );
+        $this->assertSame( "\\a943\\b\\c", backslashit( 'a943bc' ) );
     }
 
     function test_double_backslashes_leading_numbers() {
-        $this->assertEquals( '\\\\95', backslashit( '95' ) );
+        $this->assertSame( '\\\\95', backslashit( '95' ) );
     }
 
     function test_removes_trailing_slashes() {
-        $this->assertEquals( 'a', untrailingslashit( 'a/' ) );
-        $this->assertEquals( 'a', untrailingslashit( 'a////' ) );
+        $this->assertSame( 'a', untrailingslashit( 'a/' ) );
+        $this->assertSame( 'a', untrailingslashit( 'a////' ) );
     }
 
@@ -26 +26 @@
      */
     function test_removes_trailing_backslashes() {
-        $this->assertEquals( 'a', untrailingslashit( 'a\\' ) );
-        $this->assertEquals( 'a', untrailingslashit( 'a\\\\\\\\' ) );
+        $this->assertSame( 'a', untrailingslashit( 'a\\' ) );
+        $this->assertSame( 'a', untrailingslashit( 'a\\\\\\\\' ) );
     }
 
@@ -34 +34 @@
      */
     function test_removes_trailing_mixed_slashes() {
-        $this->assertEquals( 'a', untrailingslashit( 'a/\\' ) );
-        $this->assertEquals( 'a', untrailingslashit( 'a\\/\\///\\\\//' ) );
+        $this->assertSame( 'a', untrailingslashit( 'a/\\' ) );
+        $this->assertSame( 'a', untrailingslashit( 'a\\/\\///\\\\//' ) );
     }
 
     function test_adds_trailing_slash() {
-        $this->assertEquals( 'a/', trailingslashit( 'a' ) );
+        $this->assertSame( 'a/', trailingslashit( 'a' ) );
     }
 
     function test_does_not_add_trailing_slash_if_one_exists() {
-        $this->assertEquals( 'a/', trailingslashit( 'a/' ) );
+        $this->assertSame( 'a/', trailingslashit( 'a/' ) );
     }
 
@@ -50 +50 @@
      */
     function test_converts_trailing_backslash_to_slash_if_one_exists() {
-        $this->assertEquals( 'a/', trailingslashit( 'a\\' ) );
+        $this->assertSame( 'a/', trailingslashit( 'a\\' ) );
     }
 }