Changeset 48937 for trunk/tests/phpunit/tests/formatting/WPSlash.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/formatting/WPSlash.php (modified) (5 diffs)

trunk/tests/phpunit/tests/formatting/WPSlash.php

@@ -58 +58 @@
         $old = "I can't see, isn't that it?";
         $new = "I can\'t see, isn\'t that it?";
-        $this->assertEquals( $new, wp_slash( $old ) );
-        $this->assertEquals( "I can\\\\\'t see, isn\\\\\'t that it?", wp_slash( $new ) );
-        $this->assertEquals( array( 'a' => $new ), wp_slash( array( 'a' => $old ) ) ); // Keyed array.
-        $this->assertEquals( array( $new ), wp_slash( array( $old ) ) ); // Non-keyed.
+        $this->assertSame( $new, wp_slash( $old ) );
+        $this->assertSame( "I can\\\\\'t see, isn\\\\\'t that it?", wp_slash( $new ) );
+        $this->assertSame( array( 'a' => $new ), wp_slash( array( 'a' => $old ) ) ); // Keyed array.
+        $this->assertSame( array( $new ), wp_slash( array( $old ) ) ); // Non-keyed.
     }
 
@@ -69 +69 @@
     function test_preserves_original_datatype() {
 
-        $this->assertEquals( true, wp_slash( true ) );
-        $this->assertEquals( false, wp_slash( false ) );
-        $this->assertEquals( 4, wp_slash( 4 ) );
-        $this->assertEquals( 'foo', wp_slash( 'foo' ) );
+        $this->assertTrue( wp_slash( true ) );
+        $this->assertFalse( wp_slash( false ) );
+        $this->assertSame( 4, wp_slash( 4 ) );
+        $this->assertSame( 'foo', wp_slash( 'foo' ) );
         $arr      = array(
             'a' => true,
@@ -80 +80 @@
         );
         $arr['e'] = $arr; // Add a sub-array.
-        $this->assertEquals( $arr, wp_slash( $arr ) ); // Keyed array.
-        $this->assertEquals( array_values( $arr ), wp_slash( array_values( $arr ) ) ); // Non-keyed.
+        $this->assertSame( $arr, wp_slash( $arr ) ); // Keyed array.
+        $this->assertSame( array_values( $arr ), wp_slash( array_values( $arr ) ) ); // Non-keyed.
 
         $obj = new stdClass;
@@ -87 +87 @@
             $obj->$k = $v;
         }
-        $this->assertEquals( $obj, wp_slash( $obj ) );
+        $this->assertSame( $obj, wp_slash( $obj ) );
     }
 
@@ -96 +96 @@
         $old = 'single\\slash double\\\\slash triple\\\\\\slash';
         $new = 'single\\\\slash double\\\\\\\\slash triple\\\\\\\\\\\\slash';
-        $this->assertEquals( $new, wp_slash( $old ) );
-        $this->assertEquals( array( 'a' => $new ), wp_slash( array( 'a' => $old ) ) ); // Keyed array.
-        $this->assertEquals( array( $new ), wp_slash( array( $old ) ) ); // Non-keyed.
+        $this->assertSame( $new, wp_slash( $old ) );
+        $this->assertSame( array( 'a' => $new ), wp_slash( array( 'a' => $old ) ) ); // Keyed array.
+        $this->assertSame( array( $new ), wp_slash( array( $old ) ) ); // Non-keyed.
     }