Changeset 48937 for trunk/tests/phpunit/tests/formatting/WPTrimWords.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/formatting/WPTrimWords.php (modified) (6 diffs)

trunk/tests/phpunit/tests/formatting/WPTrimWords.php

@@ -17 +17 @@
     function test_trims_to_55_by_default() {
         $trimmed = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce varius lacinia vehicula. Etiam sapien risus, ultricies ac posuere eu, convallis sit amet augue. Pellentesque urna massa, lacinia vel iaculis eget, bibendum in mauris. Aenean eleifend pulvinar ligula, a convallis eros gravida non. Suspendisse potenti. Pellentesque et odio tortor. In vulputate pellentesque libero, sed dapibus velit…';
-        $this->assertEquals( $trimmed, wp_trim_words( $this->long_text ) );
+        $this->assertSame( $trimmed, wp_trim_words( $this->long_text ) );
     }
 
     function test_trims_to_10() {
         $trimmed = 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Fusce varius…';
-        $this->assertEquals( $trimmed, wp_trim_words( $this->long_text, 10 ) );
+        $this->assertSame( $trimmed, wp_trim_words( $this->long_text, 10 ) );
     }
 
     function test_trims_to_5_and_uses_custom_more() {
         $trimmed = 'Lorem ipsum dolor sit amet,[...] Read on!';
-        $this->assertEquals( $trimmed, wp_trim_words( $this->long_text, 5, '[...] Read on!' ) );
+        $this->assertSame( $trimmed, wp_trim_words( $this->long_text, 5, '[...] Read on!' ) );
     }
 
@@ -33 +33 @@
         $text    = 'This text contains a <a href="http://wordpress.org"> link </a> to WordPress.org!';
         $trimmed = 'This text contains a link&hellip;';
-        $this->assertEquals( $trimmed, wp_trim_words( $text, 5 ) );
+        $this->assertSame( $trimmed, wp_trim_words( $text, 5 ) );
     }
 
@@ -43 +43 @@
 
         $text = 'This text contains<script>alert(" Javascript");</script>. It should go.';
-        $this->assertEquals( $trimmed, wp_trim_words( $text ) );
+        $this->assertSame( $trimmed, wp_trim_words( $text ) );
 
         $text = 'This text contains<style>#css { width:expression(alert("css")) }</style>. It should go.';
-        $this->assertEquals( $trimmed, wp_trim_words( $text ) );
+        $this->assertSame( $trimmed, wp_trim_words( $text ) );
     }
 
     function test_doesnt_trim_short_text() {
         $text = 'This is some short text.';
-        $this->assertEquals( $text, wp_trim_words( $text ) );
+        $this->assertSame( $text, wp_trim_words( $text ) );
     }
 
@@ -62 +62 @@
         $actual   = wp_trim_words( $this->long_text, 20 );
         restore_previous_locale();
-        $this->assertEquals( $expected, $actual );
+        $this->assertSame( $expected, $actual );
     }
 
@@ -74 +74 @@
         $actual   = wp_trim_words( $text, 19 );
         restore_previous_locale();
-        $this->assertEquals( $expected, $actual );
+        $this->assertSame( $expected, $actual );
     }
 
@@ -81 +81 @@
      */
     function test_works_with_non_numeric_num_words() {
-        $this->assertEquals( '', wp_trim_words( $this->long_text, '', '' ) );
-        $this->assertEquals( '', wp_trim_words( $this->long_text, 'abc', '' ) );
-        $this->assertEquals( '', wp_trim_words( $this->long_text, null, '' ) );
-        $this->assertEquals( 'Lorem ipsum dolor', wp_trim_words( $this->long_text, '3', '' ) );
+        $this->assertSame( '', wp_trim_words( $this->long_text, '', '' ) );
+        $this->assertSame( '', wp_trim_words( $this->long_text, 'abc', '' ) );
+        $this->assertSame( '', wp_trim_words( $this->long_text, null, '' ) );
+        $this->assertSame( 'Lorem ipsum dolor', wp_trim_words( $this->long_text, '3', '' ) );
     }
 }