Changeset 48937 for trunk/tests/phpunit/tests/formatting/Zeroise.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/formatting/Zeroise.php (modified) (1 diff)

trunk/tests/phpunit/tests/formatting/Zeroise.php

@@ -6 +6 @@
 class Tests_Formatting_Zeroise extends WP_UnitTestCase {
     function test_pads_with_leading_zeroes() {
-        $this->assertEquals( '00005', zeroise( 5, 5 ) );
+        $this->assertSame( '00005', zeroise( 5, 5 ) );
     }
 
     function test_does_nothing_if_input_is_already_longer() {
-        $this->assertEquals( '5000000', zeroise( 5000000, 2 ) );
+        $this->assertSame( '5000000', zeroise( 5000000, 2 ) );
     }
 }