Changeset 48937 for trunk/tests/phpunit/tests/functions/anonymization.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/functions/anonymization.php (modified) (4 diffs)

trunk/tests/phpunit/tests/functions/anonymization.php

@@ -37 +37 @@
         /* Todo test ipv6_fallback mode if keeping it.*/
 
-        $this->assertEquals( $expected_result, $actual_result );
+        $this->assertSame( $expected_result, $actual_result );
     }
 
@@ -227 +227 @@
      */
     public function test_anonymize_date() {
-        $this->assertEquals( '0000-00-00 00:00:00', wp_privacy_anonymize_data( 'date', '2003-12-25 12:34:56' ) );
+        $this->assertSame( '0000-00-00 00:00:00', wp_privacy_anonymize_data( 'date', '2003-12-25 12:34:56' ) );
     }
 
@@ -235 +235 @@
     public function test_anonymize_text() {
         $text = __( 'Four score and seven years ago' );
-        $this->assertEquals( '[deleted]', wp_privacy_anonymize_data( 'text', $text ) );
+        $this->assertSame( '[deleted]', wp_privacy_anonymize_data( 'text', $text ) );
     }
 
@@ -243 +243 @@
     public function test_anonymize_long_text() {
         $text = __( 'Four score and seven years ago' );
-        $this->assertEquals( 'This content was deleted by the author.', wp_privacy_anonymize_data( 'longtext', $text ) );
+        $this->assertSame( 'This content was deleted by the author.', wp_privacy_anonymize_data( 'longtext', $text ) );
     }