WordPress.org

Make WordPress Core


Ignore:
Timestamp:
09/02/2020 12:35:36 AM (17 months ago)
Author:
SergeyBiryukov
Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/functions/wpListUtil.php

    r47780 r48937  
    692692     */
    693693    public function test_wp_list_sort( $list, $orderby, $order, $expected ) {
    694         $this->assertEquals( $expected, wp_list_sort( $list, $orderby, $order ) );
     694        $this->assertSame( $expected, wp_list_sort( $list, $orderby, $order ) );
    695695    }
    696696
     
    10171017     */
    10181018    public function test_wp_list_sort_preserve_keys( $list, $orderby, $order, $expected ) {
    1019         $this->assertEquals( $expected, wp_list_sort( $list, $orderby, $order, true ) );
     1019        $this->assertSame( $expected, wp_list_sort( $list, $orderby, $order, true ) );
    10201020    }
    10211021
Note: See TracChangeset for help on using the changeset viewer.