Changeset 48937 for trunk/tests/phpunit/tests/general/document-title.php

Timestamp:

09/02/2020 12:35:36 AM (3 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/general/document-title.php (modified) (16 diffs)

trunk/tests/phpunit/tests/general/document-title.php

@@ -81 +81 @@
         add_filter( 'pre_get_document_title', array( $this, '_short_circuit_title' ) );
 
-        $this->assertEquals( 'A Wild Title', wp_get_document_title() );
+        $this->assertSame( 'A Wild Title', wp_get_document_title() );
     }
 
@@ -102 +102 @@
 
         $this->go_to( '/' );
-        $this->assertEquals( sprintf( '%s – Just another WordPress site', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( '%s – Just another WordPress site', $this->blog_name ), wp_get_document_title() );
 
         update_option( 'show_on_front', 'posts' );
 
         $this->go_to( '/' );
-        $this->assertEquals( sprintf( '%s – Just another WordPress site', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( '%s – Just another WordPress site', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -130 +130 @@
         // Show page name on home page if it's not the front page.
         $this->go_to( get_permalink( $blog_page_id ) );
-        $this->assertEquals( sprintf( 'blog-page – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'blog-page – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -138 +138 @@
         add_filter( 'document_title_parts', array( $this, '_paged_title_parts' ) );
 
-        $this->assertEquals( sprintf( '%s – Page 4 – Just another WordPress site', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( '%s – Page 4 – Just another WordPress site', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -155 +155 @@
         add_filter( 'document_title_parts', array( $this, '_singular_title_parts' ) );
 
-        $this->assertEquals( sprintf( 'test_title – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'test_title – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -169 +169 @@
         $this->go_to( '?cat=' . self::$category_id );
 
-        $this->assertEquals( sprintf( 'test_category – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'test_category – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -175 +175 @@
         $this->go_to( '?s=test_title' );
 
-        $this->assertEquals( sprintf( 'Search Results for “test_title” – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'Search Results for “test_title” – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -181 +181 @@
         $this->go_to( '?author=' . self::$author_id );
 
-        $this->assertEquals( sprintf( 'test_author – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'test_author – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -204 +204 @@
         $this->go_to( '?post_type=cpt' );
 
-        $this->assertEquals( sprintf( 'test_cpt – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'test_cpt – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -210 +210 @@
         $this->go_to( '?year=2015' );
 
-        $this->assertEquals( sprintf( '2015 – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( '2015 – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -216 +216 @@
         $this->go_to( '?monthnum=09' );
 
-        $this->assertEquals( sprintf( 'September 2015 – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'September 2015 – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -222 +222 @@
         $this->go_to( '?day=22' );
 
-        $this->assertEquals( sprintf( 'September 22, 2015 – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'September 22, 2015 – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -228 +228 @@
         $this->go_to( '?m=404' );
 
-        $this->assertEquals( sprintf( 'Page not found – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'Page not found – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -236 +236 @@
         add_filter( 'title_tag_parts', array( $this, '_paged_post_title_parts' ) );
 
-        $this->assertEquals( sprintf( 'test_title – Page 4 – %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'test_title – Page 4 – %s', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -253 +253 @@
         add_filter( 'document_title_parts', array( $this, '_rearrange_title_parts' ) );
 
-        $this->assertEquals( sprintf( '%s – test_title', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( '%s – test_title', $this->blog_name ), wp_get_document_title() );
     }
 
@@ -270 +270 @@
         add_filter( 'document_title_separator', array( $this, '_change_title_separator' ) );
 
-        $this->assertEquals( sprintf( 'test_title %%%% %s', $this->blog_name ), wp_get_document_title() );
+        $this->assertSame( sprintf( 'test_title %%%% %s', $this->blog_name ), wp_get_document_title() );
     }