Changeset 48937 for trunk/tests/phpunit/tests/http/functions.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/http/functions.php (modified) (6 diffs)

trunk/tests/phpunit/tests/http/functions.php

@@ -26 +26 @@
         $this->assertInternalType( 'array', $response );
 
-        $this->assertEquals( 'image/jpeg', $headers['content-type'] );
-        $this->assertEquals( '40148', $headers['content-length'] );
-        $this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
+        $this->assertSame( 'image/jpeg', $headers['content-type'] );
+        $this->assertSame( '40148', $headers['content-length'] );
+        $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
     }
 
@@ -37 +37 @@
 
         $this->skipTestOnTimeout( $response );
-        $this->assertEquals( '301', wp_remote_retrieve_response_code( $response ) );
+        $this->assertSame( 301, wp_remote_retrieve_response_code( $response ) );
     }
 
@@ -45 +45 @@
 
         $this->skipTestOnTimeout( $response );
-        $this->assertEquals( '404', wp_remote_retrieve_response_code( $response ) );
+        $this->assertSame( 404, wp_remote_retrieve_response_code( $response ) );
     }
 
@@ -60 +60 @@
 
         // Should return the same headers as a HEAD request.
-        $this->assertEquals( 'image/jpeg', $headers['content-type'] );
-        $this->assertEquals( '40148', $headers['content-length'] );
-        $this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
+        $this->assertSame( 'image/jpeg', $headers['content-type'] );
+        $this->assertSame( '40148', $headers['content-length'] );
+        $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
     }
 
@@ -76 +76 @@
 
         // Should return the same headers as a HEAD request.
-        $this->assertEquals( 'image/jpeg', $headers['content-type'] );
-        $this->assertEquals( '40148', $headers['content-length'] );
-        $this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
+        $this->assertSame( 'image/jpeg', $headers['content-type'] );
+        $this->assertSame( '40148', $headers['content-length'] );
+        $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
     }
 
@@ -197 +197 @@
         // Check the host_only flag in the resulting WP_Http_Cookie.
         $cookie = wp_remote_retrieve_cookie( $response, 'test' );
-        $this->assertEquals( $cookie->domain, 'wordpress.org' );
+        $this->assertSame( $cookie->domain, 'wordpress.org' );
         $this->assertFalse( $cookie->host_only, 'host-only flag not set' );