Changeset 48937 for trunk/tests/phpunit/tests/image/editorGd.php

Timestamp:

09/02/2020 12:35:36 AM (4 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/image/editorGd.php (modified) (8 diffs)

trunk/tests/phpunit/tests/image/editorGd.php

@@ -35 +35 @@
     public function test_supports_mime_type_jpeg() {
         $gd_image_editor = new WP_Image_Editor_GD( null );
-        $expected        = imagetypes() & IMG_JPG;
-        $this->assertEquals( $expected, $gd_image_editor->supports_mime_type( 'image/jpeg' ) );
+        $expected        = (bool) ( imagetypes() & IMG_JPG );
+        $this->assertSame( $expected, $gd_image_editor->supports_mime_type( 'image/jpeg' ) );
     }
 
     public function test_supports_mime_type_png() {
         $gd_image_editor = new WP_Image_Editor_GD( null );
-        $expected        = imagetypes() & IMG_PNG;
-        $this->assertEquals( $expected, $gd_image_editor->supports_mime_type( 'image/png' ) );
+        $expected        = (bool) ( imagetypes() & IMG_PNG );
+        $this->assertSame( $expected, $gd_image_editor->supports_mime_type( 'image/png' ) );
     }
 
     public function test_supports_mime_type_gif() {
         $gd_image_editor = new WP_Image_Editor_GD( null );
-        $expected        = imagetypes() & IMG_GIF;
-        $this->assertEquals( $expected, $gd_image_editor->supports_mime_type( 'image/gif' ) );
+        $expected        = (bool) ( imagetypes() & IMG_GIF );
+        $this->assertSame( $expected, $gd_image_editor->supports_mime_type( 'image/gif' ) );
     }
 
@@ -62 +62 @@
         $gd_image_editor->resize( 100, 50 );
 
-        $this->assertEquals(
+        $this->assertSame(
             array(
                 'width'  => 75,
@@ -99 +99 @@
         );
 
-        $this->assertEquals( $expected_array, $resized );
+        $this->assertSame( $expected_array, $resized );
 
         // Now, verify real dimensions are as expected.
@@ -371 +371 @@
 
         $this->assertNotNull( $resized );
-        $this->assertEquals( $expected_array, $resized );
+        $this->assertSame( $expected_array, $resized );
 
         foreach ( $resized as $key => $image_data ) {
@@ -396 +396 @@
         $gd_image_editor->resize( 100, 50, true );
 
-        $this->assertEquals(
+        $this->assertSame(
             array(
                 'width'  => 100,
@@ -416 +416 @@
         $gd_image_editor->crop( 0, 0, 50, 50 );
 
-        $this->assertEquals(
+        $this->assertSame(
             array(
                 'width'  => 50,
@@ -441 +441 @@
         $gd_image_editor->rotate( 180 );
 
-        $this->assertEquals( $color_top_left, imagecolorat( $property->getValue( $gd_image_editor ), 99, 99 ) );
+        $this->assertSame( $color_top_left, imagecolorat( $property->getValue( $gd_image_editor ), 99, 99 ) );
     }
 
@@ -460 +460 @@
         $gd_image_editor->flip( true, false );
 
-        $this->assertEquals( $color_top_left, imagecolorat( $property->getValue( $gd_image_editor ), 0, 99 ) );
+        $this->assertSame( $color_top_left, imagecolorat( $property->getValue( $gd_image_editor ), 0, 99 ) );
     }