Changeset 48937 for trunk/tests/phpunit/tests/oembed/WpEmbed.php

Timestamp:

09/02/2020 12:35:36 AM (5 years ago)

Author:

SergeyBiryukov

Message:

Tests: First pass at using assertSame() instead of assertEquals() in most of the unit tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Props johnbillion, jrf, SergeyBiryukov.
See #38266.

File:

• trunk/tests/phpunit/tests/oembed/WpEmbed.php (modified) (13 diffs)

trunk/tests/phpunit/tests/oembed/WpEmbed.php

@@ -110 +110 @@
 
         $actual = $this->wp_embed->autoembed( $content );
-        $this->assertEquals( $content, $actual );
+        $this->assertSame( $content, $actual );
     }
 
@@ -125 +125 @@
         wp_embed_unregister_handler( $handle );
 
-        $this->assertEquals( "\nEmbedded http://example.com/embed/foo\n", $actual );
+        $this->assertSame( "\nEmbedded http://example.com/embed/foo\n", $actual );
     }
 
@@ -137 +137 @@
         $this->wp_embed->delete_oembed_caches( $post_id );
 
-        $this->assertEquals( array(), get_post_meta( $post_id, '_oembed_foo' ) );
-        $this->assertEquals( array(), get_post_meta( $post_id, '_oembed_baz' ) );
+        $this->assertSame( array(), get_post_meta( $post_id, '_oembed_foo' ) );
+        $this->assertSame( array(), get_post_meta( $post_id, '_oembed_baz' ) );
     }
 
@@ -169 +169 @@
 
         $this->assertSame( $post_id, $this->wp_embed->post_ID );
-        $this->assertEquals( $expected, get_post_meta( $post_id, $cachekey, true ) );
+        $this->assertSame( $expected, get_post_meta( $post_id, $cachekey, true ) );
         $this->assertNotEmpty( get_post_meta( $post_id, $cachekey_time, true ) );
     }
@@ -195 +195 @@
         unset( $post );
 
-        $this->assertEquals( $expected, $actual );
-        $this->assertEquals( $expected, $actual_2 );
-        $this->assertEquals( $expected, $cached );
+        $this->assertSame( $expected, $actual );
+        $this->assertSame( $expected, $actual_2 );
+        $this->assertSame( $expected, $cached );
     }
 
@@ -226 +226 @@
         unset( $post );
 
-        $this->assertEquals( $expected, $actual );
-        $this->assertEquals( '{{unknown}}', $cached );
+        $this->assertSame( $expected, $actual );
+        $this->assertSame( '{{unknown}}', $cached );
         $this->assertEmpty( $cached_time );
-        $this->assertEquals( $expected, $actual_2 );
+        $this->assertSame( $expected, $actual_2 );
     }
 
@@ -253 +253 @@
 
         $this->assertNotNull( $oembed_post_id );
-        $this->assertEquals( $expected, $post_content );
-        $this->assertEquals( $expected, $actual );
-        $this->assertEquals( $expected, $actual_2 );
+        $this->assertSame( $expected, $post_content );
+        $this->assertSame( $expected, $actual );
+        $this->assertSame( $expected, $actual_2 );
     }
 
@@ -278 +278 @@
         wp_delete_post( $oembed_post_id );
 
-        $this->assertEquals( $expected, $actual );
-        $this->assertEquals( $expected, $actual_2 );
+        $this->assertSame( $expected, $actual );
+        $this->assertSame( $expected, $actual_2 );
         $this->assertNotNull( $oembed_post_id );
-        $this->assertEquals( '{{unknown}}', $post_content );
+        $this->assertSame( '{{unknown}}', $post_content );
     }
 
@@ -322 +322 @@
         $actual = $this->wp_embed->shortcode( array( 'src' => $url ) );
 
-        $this->assertEquals( '<a href="' . esc_url( $url ) . '">' . esc_html( $url ) . '</a>', $actual );
+        $this->assertSame( '<a href="' . esc_url( $url ) . '">' . esc_html( $url ) . '</a>', $actual );
     }
 
@@ -333 +333 @@
         $actual = $this->wp_embed->shortcode( array(), $url );
 
-        $this->assertEquals( '<a href="' . esc_url( $url ) . '">' . esc_html( $url ) . '</a>', $actual );
+        $this->assertSame( '<a href="' . esc_url( $url ) . '">' . esc_html( $url ) . '</a>', $actual );
     }
 
@@ -339 +339 @@
         $url    = 'http://example.com/embed/foo';
         $actual = $this->wp_embed->run_shortcode( '[embed]' . $url . '[/embed]' );
-        $this->assertEquals( '<a href="' . esc_url( $url ) . '">' . esc_html( $url ) . '</a>', $actual );
+        $this->assertSame( '<a href="' . esc_url( $url ) . '">' . esc_html( $url ) . '</a>', $actual );
     }
 
@@ -346 +346 @@
         $actual = $this->wp_embed->maybe_make_link( $url );
 
-        $this->assertEquals( '<a href="' . esc_url( $url ) . '">' . esc_html( $url ) . '</a>', $actual );
+        $this->assertSame( '<a href="' . esc_url( $url ) . '">' . esc_html( $url ) . '</a>', $actual );
     }
 
@@ -358 +358 @@
 
         $this->wp_embed->linkifunknown = false;
-        $this->assertEquals( $url, $this->wp_embed->maybe_make_link( $url ) );
+        $this->assertSame( $url, $this->wp_embed->maybe_make_link( $url ) );
     }
 }